Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove README exclusions for support packages #15423

Closed
heaths opened this issue Sep 24, 2020 · 1 comment
Closed

Remove README exclusions for support packages #15423

heaths opened this issue Sep 24, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable
Milestone
Backlog

Comments

@heaths
Copy link
Member

heaths commented Sep 24, 2020 •
edited
Loading

Once Azure/azure-sdk-tools#404 is resolved, do whatever configuration is necessary and remove exclusions from eng/.docsettings.yml:

  - ['sdk/core/Microsoft.Azure.Core.NewtonsoftJson/README.md', '#15423']
  - ['sdk/search/Microsoft.Spatial.NewtonsoftJson/README.md', '#15423']
@heaths heaths added Search Test Debt Client This issue points to a problem in the data-plane of the library. labels Sep 24, 2020
@heaths heaths added this to the Backlog milestone Sep 24, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Sep 24, 2020
@heaths
Resolve build analysis issues
716de40 
Filed Azure#15423 to remove exclusions later.
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Sep 29, 2020
@heaths
Resolve build analysis issues
409e3a5 
Filed Azure#15423 to remove exclusions later.
heaths added a commit that referenced this issue Sep 29, 2020
@heaths
Support Microsoft.Spatial unconditionally in Search (#15387)
c865acf 
* Fix README for Microsoft.Azure.Core.NewtonsoftJson

* Add Json.NET converters for Microsoft.Spatial

Resolves #13165

* Rename converter to match Json.NET ObjectSerializer

It may be long, but it's consistent.

* Add GeometryFactory and adapter

Uses reflection to loosely bind Microsoft.Spatial types.

* Rename spatial adapters to proxies

* Proxy all supported Microsoft.Spatial types

* Update Search for current Azure.Core.GeoJson

* Encode spatial types for SearchFilter

Fixes #15299

* Implement IEquatable<GeoPosition> on GeoPosition

GeoPosition already implemented the interface, just without declaring it. May as well, so the struct doesn't have to be boxed when using EqualityComparer.Default, for example.

* Resolve PR build issues

* Resolve build analysis issues

Filed #15423 to remove exclusions later.

* Move Microsoft.Spatial support for Json.NET to core

* Remove unused methods

* Always run tests against Microsoft.Spatial

* Change GeometryPoint to GeographyPoint

* Fix README validation failure

* Resolve PR feedback

* Resolve PR feedback
@jsquire jsquire added test-reliability Issue that causes tests to be unreliable and removed Test Debt labels Jul 16, 2021
@annelo-msft annelo-msft mentioned this issue Dec 14, 2021
Closed
55 tasks
@annelo-msft
Copy link
Member

Duplicate of: #5499

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jsquire @heaths @annelo-msft