Search: Add JsonConverters for Microsoft.Spatial #13165
Assignees
Milestone
Comments
tg-msft
added
Search
Client
|
Should this be search specific? |
|
I'm not sure yet - this is more of a placeholder than a plan. If it's a lot of work to do this for ALL of Microsoft.Spatial, then we'll probably only light up the parts we need for Search and maybe Cosmos. We also need to reach out to the OData folks who own Microsoft.Spatial with a heads up and see if there's an opportunity to collaborate. |
3 tasks
heaths
added a commit
to heaths/azure-sdk-for-net
that referenced
this issue
Sep 22, 2020
heaths
added a commit
to heaths/azure-sdk-for-net
that referenced
this issue
Sep 29, 2020
heaths
added a commit
that referenced
this issue
Sep 29, 2020
* Fix README for Microsoft.Azure.Core.NewtonsoftJson * Add Json.NET converters for Microsoft.Spatial Resolves #13165 * Rename converter to match Json.NET ObjectSerializer It may be long, but it's consistent. * Add GeometryFactory and adapter Uses reflection to loosely bind Microsoft.Spatial types. * Rename spatial adapters to proxies * Proxy all supported Microsoft.Spatial types * Update Search for current Azure.Core.GeoJson * Encode spatial types for SearchFilter Fixes #15299 * Implement IEquatable<GeoPosition> on GeoPosition GeoPosition already implemented the interface, just without declaring it. May as well, so the struct doesn't have to be boxed when using EqualityComparer.Default, for example. * Resolve PR build issues * Resolve build analysis issues Filed #15423 to remove exclusions later. * Move Microsoft.Spatial support for Json.NET to core * Remove unused methods * Always run tests against Microsoft.Spatial * Change GeometryPoint to GeographyPoint * Fix README validation failure * Resolve PR feedback * Resolve PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Let's investigate releasing a support package for Track 1 customers that enables them to keep using Microsoft.Spatial types with our Track 2 library by providing JsonConverters. We should look at whether we can support both System.Text.Json and Json.NET (as separate packages).
We can start with the existing Track 1 converters at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/search/Microsoft.Azure.Search.Data/src/Customizations/Serialization/GeoJsonPointConverter.cs. Most of the work will be deciding on a strategy for releasing targeted support packages like this.
The text was updated successfully, but these errors were encountered: