Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft.Spatial support to Azure.Search.Documents #15299

Closed
3 tasks done
heaths opened this issue Sep 21, 2020 · 0 comments · Fixed by #15387
Closed
3 tasks done

Add Microsoft.Spatial support to Azure.Search.Documents #15299

heaths opened this issue Sep 21, 2020 · 0 comments · Fixed by #15387
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] October

Comments

@heaths
Copy link
Member

heaths commented Sep 21, 2020 •
edited
Loading

Since a fix for #13319 may be a way out, add support for Microsoft.Spatial that we'd need anyway to support an easy migration path for track 1 customers to track 2 if they already were using Microsoft.Spatial.

The last 2 could implement optional interfaces similar to what we did for property name conversion for FieldBuilder.
@heaths heaths added Search Client This issue points to a problem in the data-plane of the library. labels Sep 21, 2020
@heaths heaths added this to the [2020] October milestone Sep 21, 2020
@heaths heaths self-assigned this Sep 21, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Sep 24, 2020
@heaths
Encode spatial types for SearchFilter
7e8c965 
Fixes Azure#15299
This was referenced Sep 24, 2020
Merged
Closed
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Sep 29, 2020
@heaths
Encode spatial types for SearchFilter
4ae710c 
Fixes Azure#15299
heaths added a commit that referenced this issue Sep 29, 2020
@heaths
Support Microsoft.Spatial unconditionally in Search (#15387)
c865acf 
* Fix README for Microsoft.Azure.Core.NewtonsoftJson

* Add Json.NET converters for Microsoft.Spatial

Resolves #13165

* Rename converter to match Json.NET ObjectSerializer

It may be long, but it's consistent.

* Add GeometryFactory and adapter

Uses reflection to loosely bind Microsoft.Spatial types.

* Rename spatial adapters to proxies

* Proxy all supported Microsoft.Spatial types

* Update Search for current Azure.Core.GeoJson

* Encode spatial types for SearchFilter

Fixes #15299

* Implement IEquatable<GeoPosition> on GeoPosition

GeoPosition already implemented the interface, just without declaring it. May as well, so the struct doesn't have to be boxed when using EqualityComparer.Default, for example.

* Resolve PR build issues

* Resolve build analysis issues

Filed #15423 to remove exclusions later.

* Move Microsoft.Spatial support for Json.NET to core

* Remove unused methods

* Always run tests against Microsoft.Spatial

* Change GeometryPoint to GeographyPoint

* Fix README validation failure

* Resolve PR feedback

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

Support Microsoft.Spatial unconditionally in Search heaths/azure-sdk-for-net
1 participant
@heaths