[core-http] Update CHANGELOG for Oct. 2020 release #11553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
bterlson,
chradek,
daviwil and
xirzec
as code owners
ghost
added
the
sadasant
reviewed
Sep 29, 2020
sdk/core/core-http/CHANGELOG.md
Outdated
|
|
||
| - Add support for NO_PROXY and ALL_PROXY environment variables [PR 7069](https://github.com/Azure/azure-sdk-for-js/pull/7069) | ||
|
|
||
| - Serializer now resolves additionalProperties correctly from referenced mapper [PR 11473](https://github.com/Azure/azure-sdk-for-js/pull/11473) |
There was a problem hiding this comment.
Should additionalProperties be in code format? as additionalProperties?
There was a problem hiding this comment.
Yes I think so. Good point!
jeremymeng
commented
Sep 29, 2020
jeremymeng
commented
Sep 29, 2020
ramya-rao-a
reviewed
Sep 29, 2020
|
|
||
| - Add support for NDJSON format [PR 11325](https://github.com/Azure/azure-sdk-for-js/pull/11325) | ||
|
|
||
| - Add support for `NO_PROXY` and `ALL_PROXY` environment variables [PR 7069](https://github.com/Azure/azure-sdk-for-js/pull/7069) |
There was a problem hiding this comment.
Sorry for crashing late into the party, but what is ALL_PROXY?
Does our guidelines expect us to respect this?
There was a problem hiding this comment.
It's not in the list of https://github.com/Azure/azure-sdk/blob/master/_includes/tables/environment_variables.md, but ALL_PROXY can be used if no protocol specific proxy is specified, while protocol specific ones are HTTP_PROXY and HTTPS_PROXY
There was a problem hiding this comment.
My concern is that neither https://github.com/Azure/azure-sdk/blob/1f83516c03e240641de63cc3a9fd176f501183fd/_includes/tables/environment_variables.md talks about ALL_PROXY, nor https://github.com/Azure/azure-sdk/blob/a727537d54a1c71a8edd53d3e582a693b1644d74/docs/general/azurecore.md#proxy-policy
There was a problem hiding this comment.
Maybe we could submit a PR to add "ALL_PROXY" support as nice to have?
There was a problem hiding this comment.
Is the concern around whether we should have additional features that are not specified/required by guidelines?
There was a problem hiding this comment.
Yes. Especially for env variables that the Azure SDKs claim to support, the guidelines are going to be one place of truth to check what we support and we dont. I'd like to see a PR made to the guidelines to make a note of the ALL_PROXY env variable
There was a problem hiding this comment.
I didn't make change to azurecore.md because it already mentioned
... the HTTPS_PROXY (and associated) environment variables ...
There was a problem hiding this comment.
Also it looks like ALL_PROXY support for other languages is under the radar too: Azure/azure-sdk-for-java#5967 (comment)
ramya-rao-a
approved these changes
Sep 30, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 6, 2021
Network august release (Azure#12278) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 4, 2021
Network november release (Azure#13224) * Adds base for updating Microsoft.Network from version stable/2020-08-01 to version 2020-11-01 * Updates readme * Updates API version in new specs and examples * No snat firewall policy (Azure#12505) * Adding No SNAT feature support to firewall policy * committing prettier-fix * adding period at end of description to prevent failure for checks * Insights on Firewall Policy (Azure#12509) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * resolving conflicts * resolving conflicts * new api version * resolving conflicts * fixing network validation * running prettier * fixing network valdiation * fixing network valdiation Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Firewall Policy Insights with region (Azure#12711) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * resolving conflicts * resolving conflicts * new api version * resolving conflicts * fixing network validation * running prettier * fixing network valdiation * fixing network valdiation * Passing in the regions to backend * changed the reference definition Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Support for Listing IKE Security Associations for VPN Link Connections (Azure#12305) * Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01 * Updates readme * Updates API version in new specs and examples * add patch operation for express route gateway (Azure#11553) * add patch * fix example * Added new cloud service NIC and PIP APIs (Azure#11650) Co-authored-by: Richa Jain <[email protected]> * Adding support for Vpn Link Connection Mode (Azure#11574) Co-authored-by: Abhishek Shah <[email protected]> * Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754) Co-authored-by: Hari Prasad Perabattula <[email protected]> * VPN NAT for Virtual WAN feature changes (Azure#11815) * VPN NAT for Virtual WAN feature changes * PrettierCheck fixes * Incorporate review comments and update examples * Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933) * Add extendedLocation property to customIpPrefix * Fix the directory * Address linting errors * Fix another linting error * Add edge zone parameter for network interfaces * Looks like edgeZone parameter is working when creating network interfaces * EdgeZone parameter for load balancer * Add edge zone parameter for public IP address * Add edge zone parameter for public IP prefix * Add edgeZone parameter for virtual networks * Add edge zone parameter for custom IP prefix Co-authored-by: Will Ehrich <[email protected]> * Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919) * adding location parameter to backendaddresspoolpropertiesformat * ran prettier * Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572) * Support to List IKE SAs on VNG Connection * Updating GetIkeSas * Update virtualNetworkGateway.json * Added location headers * Update virtualNetworkGateway.json * Prettier fix * Update custom-words.txt * Update virtualNetworkGateway.json * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json Co-authored-by: Abhishek Shah <[email protected]> * [Fix] GetIkeSas returns result as string (Azure#12225) * Removing IkeSaParameters * Update custom-words.txt * Update virtualNetworkGateway.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionGetIkeSas.json Co-authored-by: Abhishek Shah <[email protected]> * Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039) * Remove edge zone parameter * Add extended location for private endpoint and private link service * Add examples * Capitalization * Prettier Co-authored-by: Will Ehrich <[email protected]> * Add missing properties of SecurityRule, Route and RouteTable (Azure#12215) * Add missing properties of SecurityRule Route and RouteTable * Set resourceGuid field to be read only Co-authored-by: Xu Wang <[email protected]> * Added placeholder instead of password (Azure#12299) * Adding getikesas for vpn link connections * pretty fix * Naming * Update VpnSiteLinkConnectionGetIkeSas.json * Update VpnSiteLinkConnectionGetIkeSas.json * Changing API version * Update readme.md * Updating API version * Removing changes from older API * Update virtualWan.json Co-authored-by: Mikhail <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> * Added 'Subnet' property to LoadBalancerBackendAddress (Azure#12625) * Support for ResetConnection for VNG and VPN Link connections (Azure#12715) * fix the name mismatch (Azure#12826) * Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903) * Add support for Traffic selector param in Connection - initial changes * Add trafficSelectorPolicies list in responses * Add trafficSelectorPolicies list in Get and List connection * cleanup stostools (Azure#12699) * Revert "Merge branch 'network-november-release' into ak-traffic-selector" This reverts commit 1a8f61e3c4395f410d6ff16ee41da4d2eeb091b5, reversing changes made to 3c90ff8ccb6c1e46c0480643906d6b5c5388e8c8. Co-authored-by: Zhenglai Zhang <[email protected]> * Revert "Add support for Traffic selector param in VpnConnection for virtualWan" (Azure#13088) * Revert "Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903)" This reverts commit 34dcf04f0ee453fa739ec2f790376a8decb5a3ab. * cleanup stostools (Azure#12699) Co-authored-by: Zhenglai Zhang <[email protected]> * Re - Add support for Traffic selector param in VpnConnection for virtualWan (Azure#13103) * Add support for Traffic selector param in Connection - initial changes * Add trafficSelectorPolicies list in responses * Add trafficSelectorPolicies list in Get and List connection * add auth type property to vng config (Azure#13183) * added reverted by mistake api version * fixed mistyping * Fix name mismatch for virtual network local gateway (Azure#13266) * fix the name mismatch * fix name mismatch in nov Co-authored-by: nikhilpadhye1 <[email protected]> Co-authored-by: Sai Sujith Reddy Mankala <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Richa Jain <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Abhishek Shah <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: William Ehrich <[email protected]> Co-authored-by: Will Ehrich <[email protected]> Co-authored-by: Kayden Wilkinson <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: Xu Wang <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: Akshat Kale <[email protected]> Co-authored-by: litchiyangMSFT <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: neethirshetty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.