Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-http] Update CHANGELOG for Oct. 2020 release #11553

Merged
merged 3 commits into from
Sep 30, 2020
Merged

[core-http] Update CHANGELOG for Oct. 2020 release #11553

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4078ffd
[core-http] Update CHANGELOG for Oct. 2020 release
jeremymeng Sep 29, 2020
785332d
Update sdk/core/core-http/CHANGELOG.md
jeremymeng Sep 29, 2020
fe494d5
Update sdk/core/core-http/CHANGELOG.md
jeremymeng Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sdk/core/core-http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
# Release History

## 1.1.9 (Unreleased)
## 1.1.9 (2020-09-30)

- Add support for XML namespaces in deserialization [PR 11201](https://github.com/Azure/azure-sdk-for-js/pull/11201)

- Add support for NDJSON format [PR 11325](https://github.com/Azure/azure-sdk-for-js/pull/11325)

- Add support for `NO_PROXY` and `ALL_PROXY` environment variables [PR 7069](https://github.com/Azure/azure-sdk-for-js/pull/7069)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for crashing late into the party, but what is ALL_PROXY?
Does our guidelines expect us to respect this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the list of https://github.com/Azure/azure-sdk/blob/master/_includes/tables/environment_variables.md, but ALL_PROXY can be used if no protocol specific proxy is specified, while protocol specific ones are HTTP_PROXY and HTTPS_PROXY

Copy link
Contributor

@ramya-rao-a ramya-rao-a Sep 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that neither https://github.com/Azure/azure-sdk/blob/1f83516c03e240641de63cc3a9fd176f501183fd/_includes/tables/environment_variables.md talks about ALL_PROXY, nor https://github.com/Azure/azure-sdk/blob/a727537d54a1c71a8edd53d3e582a693b1644d74/docs/general/azurecore.md#proxy-policy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could submit a PR to add "ALL_PROXY" support as nice to have?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the concern around whether we should have additional features that are not specified/required by guidelines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Especially for env variables that the Azure SDKs claim to support, the guidelines are going to be one place of truth to check what we support and we dont. I'd like to see a PR made to the guidelines to make a note of the ALL_PROXY env variable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/azure-sdk#1875

I didn't make change to azurecore.md because it already mentioned

... the HTTPS_PROXY (and associated) environment variables ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it looks like ALL_PROXY support for other languages is under the radar too: Azure/azure-sdk-for-java#5967 (comment)


- Serializer now resolves `additionalProperties` correctly from referenced mapper [PR 11473](https://github.com/Azure/azure-sdk-for-js/pull/11473)

- Empty wrapped XML element lists are no properly de-serialized. This fixes [issue 11071](https://github.com/Azure/azure-sdk-for-js/issues/11071)

## 1.1.8 (2020-09-08)

Expand Down