[core-https] "write after end" test failure on Node 14

[mikeharder]

Two tests in core-https are failing on Node 14:

  1) NodeHttpsClient
       should report upload and download progress:
     RestError: write after end
      at FakeRequest.<anonymous> (src/nodeHttpsClient.ts:139:18)
      at emitErrorNT (internal/streams/destroy.js:106:8)
      at emitErrorCloseNT (internal/streams/destroy.js:74:3)
      at processTicksAndRejections (internal/process/task_queues.js:80:21)

  2) NodeHttpsClient
       should fail if progress callbacks throw:
     Uncaught Error: it failed horribly!
      at ReportTransform.onUploadProgress (test/node/nodeHttpsClient.spec.ts:133:15)
      at ReportTransform._transform (src/nodeHttpsClient.ts:37:12)
      at ReportTransform.Transform._read (_stream_transform.js:205:10)
      at ReportTransform.Transform._write (_stream_transform.js:193:12)
      at writeOrBuffer (_stream_writable.js:352:12)
      at ReportTransform.Writable.write (_stream_writable.js:303:10)
      at ReportTransform.Writable.end (_stream_writable.js:567:10)
      at NodeHttpsClient.<anonymous> (src/nodeHttpsClient.ts:102:28)
      at Generator.next (<anonymous>)
      at /home/vsts/work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:114:75
      at new Promise (<anonymous>)
      at Object.__awaiter (/home/vsts/work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:110:16)
      at NodeHttpsClient.sendRequest (dist-test/index.node.js:1339:22)
      at Context.<anonymous> (test/node/nodeHttpsClient.spec.ts:136:28)
      at Generator.next (<anonymous>)
      at /home/vsts/work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:114:75
      at new Promise (<anonymous>)
      at Object.__awaiter (/home/vsts/work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:110:16)
      at Context.<anonymous> (dist-test/index.node.js:2829:22)
      at processImmediate (internal/timers.js:461:21)

https://dev.azure.com/azure-sdk/public/_build/results?buildId=576983&view=logs&j=5156becd-11a6-53cb-b80b-50fcb338b499&t=96b03519-0d03-5e92-2355-2d37223b59da&l=1967

[xirzec]

Seems like two bugs here: one is us sometimes calling end after pipe (which calls end implicitly) on the request, the other one appears to be related to this change which moved some errors into async: https://github.com/nodejs/node/pull/29744/files so they're not getting handled by the outer async function anymore

[ramya-rao-a]

Do these fail only in Node 14 and consistently so?

[mikeharder]

Do these fail only in Node 14 and consistently so?

yes and yes :)

[xirzec]

I have a fix, just need to get out of meeting to push the PR

[jeremymeng]

Do we need similar fix in core-http?

[xirzec]

Do we need similar fix in core-http?

Nah, this is in the new client built directly on top of the https module.