Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint Plugin] Check if the correct type definitions file is shipped #13224

Closed
deyaaeldeen opened this issue Jan 14, 2021 · 1 comment
Closed
Labels
eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@deyaaeldeen
Copy link
Member

deyaaeldeen commented Jan 14, 2021

Shipped files should be listed in the files field in package.json but sometimes there're not listed correctly causing the actual type definition file to not be included in the released package which will block TypeScript customers from using the package. To fix this, we can update the ts-package-json-files-required rule that already enforces various parts that list to also check for the type definition file. The type definition file path has to be exactly the same in three different places:

Code pointers for anyone wanting to fix this:

@deyaaeldeen deyaaeldeen self-assigned this Jan 14, 2021
@deyaaeldeen deyaaeldeen added this to the Backlog milestone Jan 14, 2021
@deyaaeldeen deyaaeldeen added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Jul 26, 2021
Copy link

Hi @deyaaeldeen, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Development

No branches or pull requests

2 participants