[Quantum Jobs] Missing "types" in the files included #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wish there is a CI step to catch the missing items from "files" section. |
sarangan12
approved these changes
Jan 26, 2021
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
|
@deyaaeldeen Is there a linter rule to catch this? |
|
@ramya-rao-a not yet but I have this open: #13224 |
|
@sarangan12 consider having the types file listed in the files field in package.json by the code generator if we do not do that already. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 25, 2021
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (Azure#13402) * Completenese for Credits,Events and Lots * Completenese for Events * Completenese for Events * Prettier updates applied. * Model Validation fix
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed adding "types" folder in the "files" section at #13385 (needed for the published package)