-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the sort-imports eslint rule #9252
Comments
Hello! Would we be adding This is my first time contributing so I'm just trying to learn how the rules works and if there's anything else that needs to be tested/checked after this rule is added. Thanks! |
The individual .eslintrc.json is to override any of the rules set in the common place i.e. in the plugin. So, you should go ahead and add it to the plugin first, run the linter for each package and fix the places where the rule fails |
Hi @ramya-rao-a, is this issue resolved, or is there further work to be done? |
Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support. |
The
sort-imports
eslint rule is pretty helpful to manage imports. Having the imports sorted helps with code reviews as well when PRs introduces a large number of imports.Code pointers for anyone wanting to fix this:
Unless there are only a couple of packages to fix, it would make pull request easier to managed if we do it in phases
The text was updated successfully, but these errors were encountered: