Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the sort-imports eslint rule #9252

Closed
ramya-rao-a opened this issue Jun 3, 2020 · 4 comments
Closed

Enable the sort-imports eslint rule #9252

ramya-rao-a opened this issue Jun 3, 2020 · 4 comments
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 3, 2020

The sort-imports eslint rule is pretty helpful to manage imports. Having the imports sorted helps with code reviews as well when PRs introduces a large number of imports.

Code pointers for anyone wanting to fix this:

Unless there are only a couple of packages to fix, it would make pull request easier to managed if we do it in phases

  1. First PR to add the rule to the plugin but treat violations as warnings
  2. Then separate PRs for fixing errors reported by the linter rule in each package.
  3. Once all of them are merged, another PR to change violations from warnings to error
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 3, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 3, 2020
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 20, 2020
@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Jul 26, 2021
@bzhang0
Copy link
Contributor

bzhang0 commented Oct 27, 2021

Hello! Would we be adding sort-imports into the base config "rules" in .\common\tools\eslint-plugin-azure-sdk? Or does this pertain to all .eslintrc.json files within all subdirectories?

This is my first time contributing so I'm just trying to learn how the rules works and if there's anything else that needs to be tested/checked after this rule is added.

Thanks!

@ramya-rao-a
Copy link
Contributor Author

The individual .eslintrc.json is to override any of the rules set in the common place i.e. in the plugin. So, you should go ahead and add it to the plugin first, run the linter for each package and fix the places where the rule fails

@kkreine
Copy link

kkreine commented Jun 26, 2022

Hi @ramya-rao-a, is this issue resolved, or is there further work to be done?

@jeremymeng jeremymeng removed the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Sep 30, 2022
Copy link

Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin
Projects
None yet
Development

No branches or pull requests

5 participants