-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linter] Added sort-imports
rule with "warning"
#18730
Conversation
Thank you for your contribution bzhang0! We will review the pull request and get back to you soon. |
Should I wait for this PR to be merged in before starting another branch to fix related directories? I remember last time in this pr (#18567) I had duplicated code in both branches (from main - this is not the exact case this time but it's relatively similar). Since this commit changes the Thanks! |
I'm seeing the following check failing.
I'm not exactly sure why this is appearing - I only added two lines and made them output with a warning as well. Could I possibly get some help regarding this issue? |
You could create new branches based on this PR branch. The commit in the PR will be included in your other PRs too but it should be fine after this PR is merged as there isn't any conflict. There is a way to make other PRs cleaner after this PR is merged (using |
@bzhang0 the monitor-query error is probably because that package has additional linting option
could you remove it and see how it goes? |
@jeremymeng yes! I will try this out |
Deleted the section, now waiting for the tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Looking into the build failure |
It's possible I forgot to rush rebuild? I'm not sure how that would impact on the remote side though. |
@bzhang0 could you please try merge the latest from upstream/main? I think there's some new changes just merged thus causing the diff between main and your PR in the eng/common folder. |
Alright! I will try |
Update readme.python.md (Azure#18730)
This PR is working in conjunction with other (upcoming) PRs to solve #9252.
As per my previous PR #18598, I will be making multiple PRs to fix individual sections of the azure codebase with respect to the new
sort-imports
rule.In this PR, I have simply added
sort-imports
incommon/tools/eslint-plugin-azure-sdk/.eslintrc.json
andazure-sdk-for-js/common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts
with a1
output (warning) or"warn"
output (also warning).