Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sort-imports] update storage-blob with respect to sort-imports rule #18953

Closed
wants to merge 3 commits into from

Conversation

bzhang0
Copy link
Contributor

@bzhang0 bzhang0 commented Dec 5, 2021

This PR is working in conjunction with other PRs to solve #9252.
As per my previous PR #18598, I will be making multiple PRs to fix individual sections of the azure codebase with respect to the new sort-imports rule.

In this PR, I have fixed all files under sdk/storage/storage-blob.

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Thank you for your contribution bzhang0! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Thank you for your contribution, bzhang0!

@bzhang0 bzhang0 changed the title [sort-imports] update storage-blob with respect to sort-imports rule [sort-imports] update storage-blob with respect to sort-imports rule Dec 5, 2021
@bzhang0
Copy link
Contributor Author

bzhang0 commented Dec 5, 2021

It seems I'm getting a lot of failed checks, which is likely due to some conflicts when I called git cherry-pick. I will revert back to a stable version and manually fix linter warnings to avoid this.

@bzhang0
Copy link
Contributor Author

bzhang0 commented Dec 5, 2021

There seems to still be tests failing, which could have occurred after I ran rushx lint --fix. I think I'll close this PR and restart :)

@bzhang0 bzhang0 closed this Dec 5, 2021
@bzhang0 bzhang0 deleted the sort-imports--storage-blob branch December 5, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant