-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sort-imports] update logger
with respect to sort-imports
rule
#19135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhang0
requested review from
deyaaeldeen,
jeremymeng and
xirzec
as code owners
December 10, 2021 09:18
ghost
added
Azure.Core
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Dec 10, 2021
Thank you for your contribution bzhang0! We will review the pull request and get back to you soon. |
ghost
added
the
Impact++
This pull request was submitted by a member of the Impact++ team.
label
Dec 10, 2021
Thank you for your contribution, bzhang0! |
deyaaeldeen
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Jun 23, 2022
Mitryakh/network 2022 01 01 (Azure#19412) * Adds base for updating Microsoft.Network from version stable/2021-08-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * Updated Explicit proxy settings by adding one boolean field to it (Azure#19011) * API for provider port (Azure#19041) * Update readme.md * Create expressRouteProviderPort.json * Create expressRouteProviderPortList.json * Create expressRouteProviderPort.json * Update custom-words.txt * Update expressRouteProviderPort.json * Update expressRouteProviderPortList.json * Update expressRouteProviderPort.json * Add WAF match variable operators (Azure#18925) ### webapplicationfirewall.json * Add GreaterThanOrEquals operator and Any operator to custom rule match conditions in WAF policy spec * Add VirtualHub Router autoscale configuration (Azure#19131) Co-authored-by: Andrii Kalinichenko <[email protected]> * Adding rule priority to Tls Proxy routing rule object model (Azure#19135) Co-authored-by: Vinay Mundada <[email protected]> * swagger changes for new ssl policies (Azure#19183) * Update Swagger Spec for VMSS Packet Capture (Azure#19202) * Update Swagger Spec for VMSS Packet Capture * Remove extra line * Update Swagger spec for Connection Monitor VMSS (Azure#19203) * Adding new endpoint in ConnectionMonitor * Changing ConnectionMonitor endpoints order * Add flushConnection to NSG (Azure#19085) * Merge NetworkManger into 2022-01-01 (Azure#19169) * Merge NetworkManger into 2022-01-01 * Remove EffectiveVnet APIs * Remove SecurityUser Resource * update readme * Fix as comments * fix as comments * remove network group type * Add new parameter noInternetAdvertise to CustomIPPrefix (Azure#19340) * fix * fix Co-authored-by: Weiheng Li <[email protected]> * Route Server Integration feature swagger changes (Azure#19215) * Route Server Integration feature swagger changes * prettier run changes * updating api version in examples file * fixing test errors * fixing test errors * fixing modelvalidation errors * fixing test errors * fixing modelvalidation errors * changes based on review comments * fixing lintdiff failure * updating examples * update wrong enum value for customipprefix (Azure#19382) * fix * fix * fix Co-authored-by: Weiheng Li <[email protected]> * Updated ExplicitProxySettings to ExplicitProxy on Firewall Policy ver2022-01-01 (Azure#19299) Co-authored-by: Gizachew Eshetie <[email protected]> * Add resource type (Azure#19434) Co-authored-by: Andrii Kalinichenko <[email protected]> * Fix prettier errors (Azure#19462) Co-authored-by: Andrii Kalinichenko <[email protected]> Co-authored-by: uditmisra52 <[email protected]> Co-authored-by: jashsing-mic <[email protected]> Co-authored-by: Anurag Kishore <[email protected]> Co-authored-by: AndriiKalinichenko <[email protected]> Co-authored-by: Andrii Kalinichenko <[email protected]> Co-authored-by: Vinay Jayant Mundada <[email protected]> Co-authored-by: Vinay Mundada <[email protected]> Co-authored-by: kaushik-ms <[email protected]> Co-authored-by: snagpal99 <[email protected]> Co-authored-by: kumaam <[email protected]> Co-authored-by: Satya-anshu <[email protected]> Co-authored-by: yanfa317 <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: Anchal Kapoor <[email protected]> Co-authored-by: Gizachew-Eshetie <[email protected]> Co-authored-by: Gizachew Eshetie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure.Core
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Impact++
This pull request was submitted by a member of the Impact++ team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working in conjunction with other PRs to fix individual sections of the azure codebase with respect to the new
sort-imports
rule, as indicated in #9252.In this PR, I have fixed all files under
sdk/core/logger
.