Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sort-imports] update eslint-plugin-azure-sdk with respect to sort-imports rule #18951

Merged

Conversation

bzhang0
Copy link
Contributor

@bzhang0 bzhang0 commented Dec 5, 2021

This PR is working in conjunction with other PRs to solve #9252.
As per my previous PR #18598, I will be making multiple PRs to fix individual sections of the azure codebase with respect to the new sort-imports rule.

In this PR, I have fixed all files under common/tools/eslint-plugin-azure-sdk.

@ghost ghost added eslint plugin customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Thank you for your contribution bzhang0! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Thank you for your contribution, bzhang0!

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@jeremymeng jeremymeng merged commit 7ba6db3 into Azure:main Jan 4, 2022
@bzhang0 bzhang0 deleted the sort-imports--eslint-plugin-azure-sdk branch January 16, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. eslint plugin Impact++ This pull request was submitted by a member of the Impact++ team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants