Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all packages that use core-http to use the newer Azure Core packages #15594

Closed
22 tasks done
ramya-rao-a opened this issue Jun 7, 2021 · 2 comments · Fixed by #26207
Closed
22 tasks done

Move all packages that use core-http to use the newer Azure Core packages #15594

ramya-rao-a opened this issue Jun 7, 2021 · 2 comments · Fixed by #26207
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Epic

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 7, 2021

We started out shipping the newer packages in November 2019 that all used the @azure/core-http package mainly that implemented pipelines and policies for making http requests. See the readme for core packages for more details.

Earlier this year, we shipped Azure Core 2.0 for JS SDKs

In May 2021, we shipped a new version of our SDK generator that supports these newer core packages by default with an option to use the older core-http

This issue is to track the work needed to ensure all our packages have been upgraded to use the new Azure Core v2.
We documented one of the package moves in a wiki which you can refer to for changes you may want to do in the hand written layer of your package to avoid any breaking changes for your customers. See core http dependency migration to core client core rest pipeline

Packages that already use the newer Azure Core v2 packages, but should be upgraded to use the output of the latest version of our SDK generator

Packages that use the older core-http, but not the code generator and should upgrade to use the newer core packages

Packages that use the older core-http, have a convenience layer over generated code and should be upgraded to use the output of the latest version of our SDK generator. You most probably have a swagger/README.md file where you have configured the use-extenstion argument to a version of @autorest/typescript. Update this to the latest beta version of https://www.npmjs.com/package/@autorest/typescript and re-generate your code

Rest of the packages that are currently purely auto-generated and so will automatically get updated the next time there is a swagger update

Benefits of the move can be found in https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-rest-pipeline/documentation/core2.md

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 7, 2021
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jun 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 7, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] December milestone Jun 7, 2021
@vishnureddy17
Copy link
Member

vishnureddy17 commented Jul 14, 2021

For folks working on this, after regenerating code don't forget to remove the dependency on core-http and add a dependency on @azure/core-client (^1.0.0) and @azure/core-rest-pipeline (^1.1.0) in your package.json and run rush update

@EmmaZhu
Copy link
Member

EmmaZhu commented May 5, 2022

#8117

@xirzec xirzec modified the milestones: [2022] April, [2022] June May 17, 2022
@xirzec xirzec modified the milestones: [2022] June, [2022] July Jun 13, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@xirzec xirzec modified the milestones: 2022-09, 2022-12 Nov 1, 2022
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
xirzec added a commit that referenced this issue Jun 15, 2023
### Packages impacted by this PR

`@azure/storage-queue`

### Issues associated with this PR

Fixes #15813
Closes #15594

### Describe the problem that is addressed by this PR

This PR migrates storage-queue to the new core pipeline in the same way
that storage-file-share was migrated. There are no changes to the public
surface and existing recorded tests still pass.

### Provide a list of related PRs _(if any)_

#26102
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants