Add EnvVar AZURE_AUTHORITY_HOST #9324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make azure resource creation can be disabled. * Fix indentation.
* Keyvault ARM template for live test.
* update to latest version of scripts * update archetype-sdk-tests.yml to use latest version of resource allocation scripts * enable cosmos testing * remove environment variable indirection, add test application oid explicitly into call to new-testresources.ps1 * Revert "enable cosmos testing" This reverts commit 827ed00.
…nt variable name, fixed transient test that was missing a sleep (#7352)
…ainer (#7259) * Initial commit to add API to retrieve min throughput for a CosmosContainer * Adding tests and using SqlQuerySpec to fetch the offer throughput for a container
* Support AM/PM in MSI token * Fix tests * Use SerializerAdapter * opens implementation to jackson * Remove deserialization in msi token test * Revert back to default locale * Remove unused import
* readme fix/ hanges * more read me changes and adding metadata
* Update identity to 1.0.3 * Add change log for 1.0.3
* Moved packages in sdk/cosmosdb to sdk/cosmos. * Adjust trigger paths. * Added management excludes.
* Update documentation and in-memory checkpoint store sample * Remove unused imports
* Update docsettings.yml * Fix changelog and readme issues.
* Add AmqpLinkMessageProcessor and partition async consumer. * Add AmqpReceiveLinkProcessor and test. * Connect AMQP link processor to EventHubConsumer. * Adding tests for EventHubPartitionAsyncConsumer. * Fix bug where we're constantly asking for more connections. * Pass Supplier for EventPosition. * Update to getScopeFromResource. * Update RetryUtil to log more information. * Adding ReactorConnection to handle transient errors. * Passing reference to parent connection for disposed.
* Add HttpPipeline adapter for MSAL IHttpClient * Build backward compatible identity client options * Fix code styles * Clean up pom * Fix netty module version * Use default when HttpPipeline is not specified * Update msal4j in eventhubs * Checkstyle * Checkstyle * Add azure-core-http-netty to identity pom.service.xml * Add azure-core-test to identity pom.service.xml * Update MSAL to 1.3.0 * Some cr feedback * Add GSON test dependency to identity * Add back test verification of client certificate
* Removing dependency on java.desktop module. * Tweak error wording * toLowerCase(Locale.ROOT) Co-authored-by: Jianghao Lu <[email protected]>
check-enforcer did not complete the evaluation. @mitchdenny is going to disable it for now.
* Updated download to file write to file logic * Updated test validation logic, added another file download test * Update FluxUtil.writeFile to duplicate buffers being written to file given there status is unknown to the method * Moved buffering into the download to file code to make back porting this change easier
* Build system updates to prep for automatic version bump and pre-release verifications (#7281)
…erlying ByteBuffer may be reclaimed before written (#7476)
* Updating post release versions to 3.7.0-beta.1 * Updating readme to released version
- Add client constants class to maintains all constants for App configuration client. - 'id' is a type of String, could be null or empty - Added tests for code coverage for ConfigurationClientBuilder and ``SettingSelector.
…xes (#7479) * Replace AutoCloseable with Disposable * Update ReactorConnection and Session to use Disposable. * Update implementation classes to use Receiver/Sender to Dispose. * Fix error handling for tracing by ending with doOnError * Do not request another connection when retry is pending.
* Eventhubs ARM template for live test
* Adjust conditions to better handle cancellations. * Reacting to Mike's feedback.
* Retry network operations in resources scripts * Pass -CI switch parameter
* PagedFluxCore as an abstraction for generic paging (not tied to protocol e.g. http) * Making PagedFluxCore abstract, letting user to define state type * Making the Paged Flux type more flexiable * Adding byItem(token) and some cleanup. * Code cleanup and adding javadoc code-snippets for PagedFluxCore * Moving paging base types to util package, adding exclusions for paging code-snippets * Making the base Paged Flux completely abstract, exposing prefetch for the default implementation of paged flux * Enabling a way to decorate a PagedFlux and have that decoreated type as PagedFlux, this will help us from not exposing more-more flux operator on PagedFlux, enable Continuation-option in base abstract type * Removed unused internal ctr * Update sdk/core/azure-core/src/main/java/com/azure/core/util/paging/ContinuationState.java Co-Authored-By: Alan Zimmer <[email protected]> * cleaning up comments and simplifying the code * Update sdk/core/azure-core/src/main/java/com/azure/core/http/rest/PagedFlux.java Co-Authored-By: Alan Zimmer <[email protected]> * Removing generic arg for contination option, adding sample for PagedFlux decoration * Simplifying ContinuablePagedFluxCore concat logic and updating the PagedIterableTests to assert for the correct behavior we're looking for. * Adding getElements() to Page that return elements as iterable-stream, deprecating getItems() that return list. * Moving deprecated getItems() to REST Page * Checking for null page items before creating IterableStream, Fixing the bug of not sending token in provider based mapPage impl * Re-recording data lake test as we no longer make extra network call * Handle the case where byPage(ct) can be invoked on a PagedFlux created by mapPage() API * re-record datalake tests using PagedFlux/PagedIterable * Removing interface type PageRetrievalProvider * Adding preferred page size option * javadoc updates for PagedFlux types * javadoc update, use null instead of -1 for no page-size * Udating keyvault, storage-blob-batch and azure-core-test referenced version of azure-core to 1.2.0 (to get new page abstractions) * Fixing checkstyles in textanalytics samples * Explicitly specify type in code-snippet * updating azure-core version of kevault-certificates, keys, secrets, storage-batch, azure-core-test to unreleased 1.2.0 * Adding revapi supression for new base ContinuablePagedFluxCore * bump up azure-core versions of client-libs that uses new page types * javadoc improvments * Page::getElements() should not return null * PagedFlux javadoc update Co-Authored-By: Jonathan Giles <[email protected]> * Adding IterableStream::of(Iterable) factory method Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jonathan Giles <[email protected]>
* Update Reactor to schedule pending tasks before completing. * Fix bug where clean up task was not scheduled immediately * Dispose of session when closed in Connection. * Cleaning up sessions when they die. * Use single map to keep track of sessions. * AmqpConnection does not keep track of open links. * Use the same link name for creating producers. * Use retry in entire getLinkSize operation. * Defer creation of send work item * Manage send and receive links in ReactorSession. * Add class for long running, disabled, tests. * Fix log messages. Do not return management node if there is an exception. * Update RequestResponseChannel to listen to endpoint states. * Adding support for management channel to fetch new instance if it is idled or closed. * ConnectionProcessor uses AmqpCHannelProcessor.
srnagar
reviewed
Mar 20, 2020
| @@ -83,7 +88,7 @@ | |||
| /** | |||
| * Name of the Azure cloud to connect to. | |||
| */ | |||
| public static final String PROPERTY_AZURE_CLOUD = "AZURE_CLOUD"; | |||
There was a problem hiding this comment.
Removing/renaming a public env variable that is already released is considered a breaking change. Can this env var be retained and PROPERTY_AZURE_AUTHORITY_HOST be added as a new env var?
Comment on lines
+58
to
+63
| String clientId = configuration.get(Configuration.PROPERTY_AZURE_CLIENT_ID); | ||
| String tenantId = configuration.get(Configuration.PROPERTY_AZURE_TENANT_ID); | ||
| String clientSecret = configuration.get(Configuration.PROPERTY_AZURE_CLIENT_SECRET); | ||
| String certPath = configuration.get(Configuration.PROPERTY_AZURE_CLIENT_CERTIFICATE_PATH); | ||
| String username = configuration.get(Configuration.PROPERTY_AZURE_USERNAME); | ||
| String password = configuration.get(Configuration.PROPERTY_AZURE_PASSWORD); |
There was a problem hiding this comment.
Any reason these have to be initialized synchronously?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EnvVar AZURE_AUTHORITY_HOST to azure.identity._constants.
TokenCredentialOptions has an AuthorityHost property.
This will be modified to support EnvVar override with AZURE_AUTHORITY_HOST.
/issues/5967