Fix cancellation handling #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
requested review from
danieljurek,
JimSuplizio and
weshaggard
as code owners
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mikeharder
requested changes
Jan 15, 2020
mitchdenny
force-pushed
the
fix-cancellation
branch
from
799963d to
03af12b
Compare
mikeharder
approved these changes
Jan 16, 2020
weshaggard
approved these changes
Jan 16, 2020
JimSuplizio
reviewed
Jan 16, 2020
| @@ -253,7 +253,7 @@ jobs: | |||
|
|
|||
| - task: Maven@3 | |||
| displayName: 'Start Jetty' | |||
| condition: ne('${{ parameters.SDKType }}', 'client') | |||
| condition: and(succeeded(), ne(variables['SdkType'], 'client')) | |||
There was a problem hiding this comment.
@mitchdenny why was this changed from parameters back to variables? Variables is going to try and pull from the pipeline variable SDKType which isn't set for every pipeline. Using the parameters should, in theory, guarantee that this only runs for the correct track.
There was a problem hiding this comment.
My bad ... I'll fix it up now. I was getting shown some interesting conflict resolutions when I did my rebase.
JimSuplizio
reviewed
Jan 16, 2020
Fixed up in this PR: #7512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends/adjusts conditions on tasks and jobs to better handle cancellations. We have some tasks in jobs with an
always()condition which effectively stops that job being cancelled. We need to avoid that in most cases because we generally need to cancel jobs in an build storm andalways()conditions slow down recovery time.