Skip to content

Commit

Permalink
Reacting to Mike's feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
mitchdenny committed Jan 15, 2020
1 parent 6cd23cb commit 03af12b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
# builds should be sufficient.
condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
condition: and(succeededOrFailed(), ne(variables['Build.Reason'], 'PullRequest'))
displayName: 'Component Detection'

# We `install` the code quality reports tooling into our local m2 cache separately from building the Maven project
Expand Down Expand Up @@ -311,7 +311,7 @@ jobs:
condition: and(succeeded(), or(ne(variables['TestFromSource'],'true'), eq(variables['ShouldRunSourceTests'],'true')))

- task: PublishTestResults@2
condition: and(succeededOrFailed(), or(ne(variables['TestFromSource'],'true'), eq(variables['ShouldRunSourceTests'],'true')))
condition: and(always(), or(ne(variables['TestFromSource'],'true'), eq(variables['ShouldRunSourceTests'],'true')))
inputs:
mergeTestResults: true
testRunTitle: $(RunTitle)
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
- task: PublishTestResults@2
condition: succeededOrFailed()
condition: always()
inputs:
mergeTestResults: true
testRunTitle: 'Live tests for ${{ parameters.ServiceDirectory }} $(DisplayName)'
Expand Down

0 comments on commit 03af12b

Please sign in to comment.