Added third party notice txt #7387

sima-zhu · 2020-01-13T16:37:49Z

No description provided.

srnagar · 2020-01-13T17:25:39Z

THIRD-PARTY-NOTICE.txt

+License notice for Azure SDK for Java
+-------------------------------
+
+Copyright (c) 2015 Microsoft. All rights reserved.


Is this the right text? All our class files use the following license (no 2015 in the license we use for track 2). Maybe we should update LICENSE.txt too?

// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License.

alzimmermsft

Are the licenses listed for top level imports only?

JonathanGiles · 2020-01-13T20:02:45Z

THIRD-PARTY-NOTICE.txt

+
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/


We discussed how to do apache after you asked about it, and I pointed you the correct way to do it. This wasn't it - we should just link out to the text rather than reproduce it.

You asked me to check the example you gave to me. They put the text over instead of link. Some of the dependency put the text like this exactly in their license. Do we want to paste the link directly?

sima-zhu · 2020-01-13T21:26:54Z

Are the licenses listed for top level imports only?

Yes. I only have the direct imports.

JonathanGiles · 2020-01-13T23:21:25Z

THIRD-PARTY-NOTICE.txt

+License notice for Azure SDK for Java
+-------------------------------
+
+Copyright (c) Microsoft. All rights reserved.
+Licensed under The MIT License (MIT)
+
+Available at
+https://github.com/Azure/azure-sdk-for-java/blob/master/LICENSE.txt


You don't need to include the azure-sdk-for-java license in the third-party licenses document.

JonathanGiles · 2020-01-13T23:23:38Z

THIRD-PARTY-NOTICE.txt

+Available at
+https://github.com/Azure/azure-sdk-for-java/blob/master/LICENSE.txt
+
+License notice for org.hamcrest:hamcrest-library:2.2


You should present this more nicely - have the name of the library, not it's Maven GAV. e.g. this should just be 'License notice for Hamcrest'. Also, as discussed, you need to bring in the copyright information, e.g. https://github.com/hamcrest/JavaHamcrest/blob/master/LICENSE.txt

JonathanGiles · 2020-01-14T00:12:33Z

THIRD-PARTY-NOTICE.txt

+ See the License for the specific language governing permissionsand
+ limitations under the License.
+
+License notice for Jackson Dataformat


This should be Databind?

JonathanGiles · 2020-01-14T00:13:15Z

THIRD-PARTY-NOTICE.txt

+
+http://www.apache.org/licenses/LICENSE-2.0
+
+License notice for Google Findbugs


Where is Findbugs used?

mitchdenny · 2020-01-14T00:20:04Z

/check-enforcer reset

JonathanGiles · 2020-01-14T00:14:15Z

THIRD-PARTY-NOTICE.txt

+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+License notice for Nimbusds


Nimbusds has a lot of projects under it, like Jackson - please be more specific.

JonathanGiles · 2020-01-14T00:16:19Z

THIRD-PARTY-NOTICE.txt

+License notice for Opencensus Api
+------------------------------------------------------------------------------
+
+   CCopyright 2017, OpenCensus Authors
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.


I don't believe we use OpenCensus any longer - check with @samvaity

Confirmed with Sameeksha, this one has been removed. Remove from PR too

JonathanGiles · 2020-01-14T00:16:30Z

THIRD-PARTY-NOTICE.txt

+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+License notice for Opentelemetry Api


'OpenTelemetry' and 'API'

JonathanGiles · 2020-01-14T00:17:10Z

THIRD-PARTY-NOTICE.txt

+   Copyright 2017, OpenCensus Authors
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+License notice for Opentelemetry SDK
+------------------------------------------------------------------------------
+
+   Copyright 2017, OpenCensus Authors
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.


Is OpenTelemetry still copyright to OpenCensus or is this a typo?

JonathanGiles · 2020-01-14T00:17:49Z

THIRD-PARTY-NOTICE.txt

+
+JUnit
+
+Eclipse Public License - v 1.0


Just link to EPL rather than recreate all the text.

JonathanGiles · 2020-01-14T00:19:08Z

THIRD-PARTY-NOTICE.txt

+
+This Agreement is governed by the laws of the State of New York and the intellectual property laws of the United States of America. No party to this Agreement will bring a legal action under this Agreement more than one year after the cause of action arose. Each party waives its rights to a jury trial in any resulting litigation.
+
+License notice for org.jacoco:org.jacoco.agent:0.8.4:runtime


Use nice name

JonathanGiles · 2020-01-14T00:20:25Z

THIRD-PARTY-NOTICE.txt

+
+### 4. Commercial Distribution
+
+Commercial distributors of software may accept certain 


Same as with EPL

samvaity · 2020-01-14T01:08:23Z

THIRD-PARTY-NOTICE.txt

+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+License notice for Opentelemetry SDK


Are we doing this for test dependencies too?
Opentelemetry SDK is a test dependency.

Also, License notice for OpenTelemetry SDK

Yes, we need to include test dependencies.
Made the change

samvaity · 2020-01-14T01:15:21Z

THIRD-PARTY-NOTICE.txt

+License notice for OpenTelemetry API
+------------------------------------------------------------------------------
+
+   Copyright 2017, OpenTelemetry Authors


Also, the year should 2019.

Suggested change

Copyright 2017, OpenTelemetry Authors

Copyright 2019, OpenTelemetry Authors

JonathanGiles · 2020-01-14T02:03:24Z

THIRD-PARTY-NOTICE.txt

+License notice for Wiremock
+------------------------------------------------------------------------------
+
+Copyright (C) 2011 Thomas Akehurst
+
+This copy of Jackson JSON processor databind module is licensed under the
+Apache (Software) License, version 2.0 ("the License").
+See the License for details about distribution rights, and the
+specific rights regarding derivate works.
+
+You may obtain a copy of the License at:
+
+http://www.apache.org/licenses/LICENSE-2.0


Wiremock / Jackson issue

JonathanGiles · 2020-01-14T02:05:40Z

THIRD-PARTY-NOTICE.txt

+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+License notice for org.nanohttpd:nanohttpd:2.3.1


Missing newline before this.

JonathanGiles

LGTM. Get a @joshfree approval and then it is probably good to go.

mitchdenny · 2020-01-14T09:24:40Z

/check-enforcer reset

mitchdenny · 2020-01-14T09:24:48Z

/check-enforcer evaluate

joshfree · 2020-01-14T16:06:54Z

LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)

-Copyright (c) 2015 Microsoft
+Copyright (c) Microsoft


why are you changing the LICENSE.txt at all as part of this change? I would just revert this file entirely and not up date it.

Revert back

joshfree

How was the list generated?

joshfree · 2020-01-14T16:10:02Z

THIRD-PARTY-NOTICE.txt

+
+http://www.apache.org/licenses/LICENSE-2.0
+
+License notice for Wiremock


How was this list generated? We only need to add entries for things where we've incorporated the source code from other projects or where we are redistributing other open source projects.

joshfree · 2020-01-14T16:11:01Z

THIRD-PARTY-NOTICE.txt

+License notice for Junit
+------------------------------------------------------------------------------
+
+JUnit


Are we redistributing JUnit somehow? If not, this shouldn't be here.

joshfree · 2020-01-14T16:11:22Z

THIRD-PARTY-NOTICE.txt

+See the License for the specific language governing permissions and
+limitations under the License.
+
+License notice for Groovy Eclipse Compiler


joshfree · 2020-01-14T16:11:33Z

THIRD-PARTY-NOTICE.txt

+See the License for the specific language governing permissions and
+limitations under the License.
+
+License notice for Jacoco Agent


same for Jacoco

mitchdenny · 2020-01-14T22:32:44Z

/check-enforcer reset

joshfree

Approved initial commit. With initial list.

sima-zhu requested review from JonathanGiles and joshfree January 13, 2020 16:38

srnagar approved these changes Jan 13, 2020

View reviewed changes

alzimmermsft approved these changes Jan 13, 2020

View reviewed changes

JonathanGiles reviewed Jan 13, 2020

View reviewed changes

sima-zhu requested a review from JonathanGiles January 13, 2020 23:14

JonathanGiles reviewed Jan 13, 2020

View reviewed changes

JonathanGiles reviewed Jan 14, 2020

View reviewed changes

JonathanGiles requested changes Jan 14, 2020

View reviewed changes

samvaity reviewed Jan 14, 2020

View reviewed changes

JonathanGiles reviewed Jan 14, 2020

View reviewed changes

sima-zhu requested a review from JonathanGiles January 14, 2020 03:23

JonathanGiles approved these changes Jan 14, 2020

View reviewed changes

joshfree reviewed Jan 14, 2020

View reviewed changes

joshfree requested changes Jan 14, 2020

View reviewed changes

sima-zhu requested a review from joshfree January 14, 2020 22:23

revert license changes

5da6e46

sima-zhu force-pushed the thirdpartynotice branch from eafc45e to 5da6e46 Compare January 14, 2020 22:49

joshfree approved these changes Jan 15, 2020

View reviewed changes

sima-zhu merged commit a5aba4c into Azure:master Jan 15, 2020

sima-zhu deleted the thirdpartynotice branch July 13, 2020 16:51


		http://www.apache.org/licenses/LICENSE-2.0

		License notice for Google Findbugs


		This Agreement is governed by the laws of the State of New York and the intellectual property laws of the United States of America. No party to this Agreement will bring a legal action under this Agreement more than one year after the cause of action arose. Each party waives its rights to a jury trial in any resulting litigation.

		License notice for org.jacoco:org.jacoco.agent:0.8.4:runtime


		### 4. Commercial Distribution

		Commercial distributors of software may accept certain

	Copyright 2017, OpenTelemetry Authors
	Copyright 2019, OpenTelemetry Authors


		http://www.apache.org/licenses/LICENSE-2.0

		License notice for Wiremock

Added third party notice txt #7387

Added third party notice txt #7387

Conversation

sima-zhu commented Jan 13, 2020

Choose a reason for hiding this comment

alzimmermsft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sima-zhu commented Jan 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchdenny commented Jan 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samvaity Jan 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JonathanGiles left a comment

Choose a reason for hiding this comment

mitchdenny commented Jan 14, 2020

mitchdenny commented Jan 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshfree left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mitchdenny commented Jan 14, 2020

joshfree left a comment

Choose a reason for hiding this comment

samvaity Jan 14, 2020 •

edited

Loading