Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AutoCloseable with reactor's Disposable. Retry and timeout fixes #7479

Merged
merged 10 commits into from
Jan 16, 2020

Conversation

conniey
Copy link
Member

@conniey conniey commented Jan 15, 2020

  • Replace AutoCloseable with Disposable.
    • In the next PR, if the parent is already disposed, we don't want to re-create its child. AutoCloseable doesn't have a way to query the current status of an AMQP channel.
    • Example: If a connection is closed, we don't want to re-create a session from that channel. And if a session is closed, we don't want to create links from it.
  • Fixes bug where when a transient error occurs, and while waiting for the retry period to elapse, if a new subscriber comes in, it'll immediately try to get a new connection, rather than waiting for that retry period to elapse.
  • Fixes bug where TimeoutException would occur in doOnEach.
<10484.19> 01/12/2020 23:51:54 - Error: JAVA-Sender#0<stdout>: : Client index 0: Error occurred. java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 60000ms in 'doOnEach' (and no fallback has been configured)
<10484.19> 01/12/2020 23:51:54 - Error: JAVA-Sender#0<stdout>:  Exception caught (Identifier: Client index 0): class java.util.concurrent.TimeoutException Did not observe any item or terminal signal within 60000ms in 'doOnEach' (and no fallback has been configured)

@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jan 15, 2020
@conniey conniey requested a review from srnagar January 15, 2020 19:30
@conniey conniey self-assigned this Jan 15, 2020
@conniey conniey merged commit 9b198d6 into Azure:master Jan 16, 2020
@conniey conniey deleted the use-disposable branch January 16, 2020 03:48
@JonathanGiles
Copy link
Member

JonathanGiles commented Jan 16, 2020

This looks like a breaking API change? Has this not been published as a GA release yet?

@conniey
Copy link
Member Author

conniey commented Jan 16, 2020

@JonathanGiles No. This is still a -beta.6. It has not been GA'd yet. We're hoping to make it GA on Friday with 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants