-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace AutoCloseable with reactor's Disposable. Retry and timeout fixes #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
conniey
commented
Jan 15, 2020
- Replace AutoCloseable with Disposable.
- In the next PR, if the parent is already disposed, we don't want to re-create its child. AutoCloseable doesn't have a way to query the current status of an AMQP channel.
- Example: If a connection is closed, we don't want to re-create a session from that channel. And if a session is closed, we don't want to create links from it.
- Fixes bug where when a transient error occurs, and while waiting for the retry period to elapse, if a new subscriber comes in, it'll immediately try to get a new connection, rather than waiting for that retry period to elapse.
- Fixes bug where TimeoutException would occur in doOnEach.
conniey
added
Event Hubs
Client
This issue points to a problem in the data-plane of the library.
labels
Jan 15, 2020
conniey
requested review from
alzimmermsft,
hemanttanwar,
jianghaolu and
mssfang
as code owners
January 15, 2020 19:30
srnagar
approved these changes
Jan 15, 2020
This looks like a breaking API change? Has this not been published as a GA release yet? |
@JonathanGiles No. This is still a -beta.6. It has not been GA'd yet. We're hoping to make it GA on Friday with 1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.