Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix OneDeploy request and response bodies" #26580

Merged

Conversation

kamperiadis
Copy link
Contributor

Reverts #23224

@kamperiadis kamperiadis requested a review from naveedaz as a code owner November 6, 2023 23:10
Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
WebApps.json 2023-01-01(cf14916) 2022-09-01(main)
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️SDK Breaking Change Tracking warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-python-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/501c889e972643808f725a9d2ca495ef
Java azure-resourcemanager-appservice-generated https://apiview.dev/Assemblies/Review/267c96352a184fceaecf14bf2782c34c
JavaScript @azure/arm-appservice https://apiview.dev/Assemblies/Review/a6500291c5d64375b1ceb93265e9edae

@kamperiadis
Copy link
Contributor Author

/pr RequestMerge

@naveedaz naveedaz enabled auto-merge (squash) November 8, 2023 17:54
@zizw123
Copy link

zizw123 commented Nov 8, 2023

Approving the lint as this is a revert

@naveedaz naveedaz merged commit 5ef0718 into release-web-2023-01-01 Nov 8, 2023
21 of 26 checks passed
@naveedaz naveedaz deleted the revert-23224-release-web-2023-01-01 branch November 8, 2023 18:02
naveedaz added a commit that referenced this pull request Nov 10, 2023
* Add new api-version 2023-01-01 (#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (#23084)

* Fix OneDeploy request and response bodies (#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (#24102)

Co-authored-by: Vishal Gupta <[email protected]>

* Add minTlsCipherSuite property (#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Dapr configuration for a site (#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Fix for JS SDK check failure for Dapr Config (#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Release web 2023 01 01 (#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a11107.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Release web 2023 01 01 (#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a11107.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Adding workload profile & resource config to Site (#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (#23224)" (#26580)

This reverts commit 7dfc303.

---------

Co-authored-by: Alex Karcher <[email protected]>
Co-authored-by: dannysongg <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: SushmithaVReddy <[email protected]>
Co-authored-by: Sushmitha Vangala <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: mukundnigam <[email protected]>
Co-authored-by: Kirstyn Amperiadis <[email protected]>
Co-authored-by: Haochi <[email protected]>
zman-ms pushed a commit that referenced this pull request Jan 10, 2024
* Add new api-version 2023-01-01 (#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (#23084)

* Fix OneDeploy request and response bodies (#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (#24102)

Co-authored-by: Vishal Gupta <[email protected]>

* Add minTlsCipherSuite property (#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Dapr configuration for a site (#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Fix for JS SDK check failure for Dapr Config (#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Release web 2023 01 01 (#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a11107.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Release web 2023 01 01 (#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a11107.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Adding workload profile & resource config to Site (#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (#23224)" (#26580)

This reverts commit 7dfc303.

---------

Co-authored-by: Alex Karcher <[email protected]>
Co-authored-by: dannysongg <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: SushmithaVReddy <[email protected]>
Co-authored-by: Sushmitha Vangala <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: mukundnigam <[email protected]>
Co-authored-by: Kirstyn Amperiadis <[email protected]>
Co-authored-by: Haochi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants