Release web 2023 01 01 #26545
Merged
Release web 2023 01 01 #26545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new api-version 2023-01-01 * Change default package api-version
* Fix OneDeploy request and response bodies * Fixing typo
Co-authored-by: Vishal Gupta <[email protected]>
* Add minTlsCipherSuite property * Move to SiteConfig --------- Co-authored-by: Chris Rosenblatt <[email protected]>
* Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail --------- Co-authored-by: Sushmitha Vangala <[email protected]>
* Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail * JS Sdk check fail fix --------- Co-authored-by: Sushmitha Vangala <[email protected]>
* Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments --------- Co-authored-by: Rohini Sharma <[email protected]>
* Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments * Removing quota type parameter --------- Co-authored-by: Rohini Sharma <[email protected]>
* Adding workload profile & resource config to Site * prettier fix * cosmetic fix * updating examples * prettier fix
* Rename log level enum for dapr * Fix Python SDK failure for Dapr log level config
* Rename log level num for dapr * Rename log level num for dapr
* initial change to add ase regions * addressing comments * nit adding example as suggested * formatting code * add custom word * prettier everything * prettier everything
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| AppServiceCertificateOrders.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| CertificateOrdersDiagnostics.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| CertificateRegistrationProvider.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| DomainRegistrationProvider.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Domains.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| TopLevelDomains.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| AppServiceEnvironments.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| AppServicePlans.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Certificates.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| CommonDefinitions.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| ContainerApps.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| ContainerAppsRevisions.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| DeletedWebApps.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Diagnostics.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Global.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| KubeEnvironments.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Provider.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| Recommendations.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| ResourceHealthMetadata.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| ResourceProvider.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| StaticSites.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
| WebApps.json | 2023-01-01(5ef0718) | 2022-09-01(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
@weidongxu-microsoft Can we please merge this service branch into main once the validations pass? |
AzureRestAPISpecReview
added
ARMReview
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @naveedaz! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
kamperiadis
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
@rkmanda @weidongxu-microsoft Can you please review this PR again? The validation failure has been resolved. Thank you! |
It looks like not all commits have been reviewed by ARM, some of them are missing ARMSigned off, if you can follow this guide and add base version, we can do a quick pass on the diff for this new API version. |
zizw123
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
zizw123
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
zizw123
reviewed
Nov 9, 2023
| "description": "Zone redundant deployment enabled.", | ||
| "type": "boolean", | ||
| "readOnly": true | ||
| }, |
There was a problem hiding this comment.
non-blocking, consider use enum over boolean for easier expansion if needed in future
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Alancere
added
the
Approved-SdkBreakingChange-Go
|
/pr RequestMerge |
pvbchak
approved these changes
Nov 10, 2023
|
/pr RequestMerge |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Nov 10, 2023
Closed
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Add new api-version 2023-01-01 (#22962) * Add new api-version 2023-01-01 * Change default package api-version * Updated workflowstate to be a reference (#23084) * Fix OneDeploy request and response bodies (#23224) * Fix OneDeploy request and response bodies * Fixing typo * Add Container Apps Environment Id in checknameavailability API (#24102) Co-authored-by: Vishal Gupta <[email protected]> * Add minTlsCipherSuite property (#24198) * Add minTlsCipherSuite property * Move to SiteConfig --------- Co-authored-by: Chris Rosenblatt <[email protected]> * Dapr configuration for a site (#24606) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Fix for JS SDK check failure for Dapr Config (#25493) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail * JS Sdk check fail fix --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Release web 2023 01 01 (#25157) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments --------- Co-authored-by: Rohini Sharma <[email protected]> * Release web 2023 01 01 (#25629) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments * Removing quota type parameter --------- Co-authored-by: Rohini Sharma <[email protected]> * Adding workload profile & resource config to Site (#25868) * Adding workload profile & resource config to Site * prettier fix * cosmetic fix * updating examples * prettier fix * Fix Python SDK failure for Dapr log level config (#26198) * Rename log level enum for dapr * Fix Python SDK failure for Dapr log level config * Rename log level num for dapr (#26374) * Rename log level num for dapr * Rename log level num for dapr * initial change to add ase regions (#26333) * initial change to add ase regions * addressing comments * nit adding example as suggested * formatting code * add custom word * prettier everything * prettier everything * Revert "Fix OneDeploy request and response bodies (#23224)" (#26580) This reverts commit 7dfc303. --------- Co-authored-by: Alex Karcher <[email protected]> Co-authored-by: dannysongg <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: SushmithaVReddy <[email protected]> Co-authored-by: Sushmitha Vangala <[email protected]> Co-authored-by: rohinisharma <[email protected]> Co-authored-by: Rohini Sharma <[email protected]> Co-authored-by: mukundnigam <[email protected]> Co-authored-by: Kirstyn Amperiadis <[email protected]> Co-authored-by: Haochi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.