Release web 2023 01 01 #25157

rohinisharma · 2023-08-03T16:30:22Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- Adding public usages API with quota type parameter for onboarding onto QMS. This API has been implemented by other RPs such as Microsoft.Compute already.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ X] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

This reverts commit 4a11107.

…e-rest-api-specs into release-web-2023-01-01

openapi-workflow-bot · 2023-08-03T16:30:26Z

Hi, @rohinisharma! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-08-03T16:30:26Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
ResourceProvider.json	2023-01-01(5ba3db2)	2022-09-01(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-01	package-2023-01(5ba3db2)	package-2023-01(release-web-2023-01-01)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` TopLevelResourcesListBySubscription	The top-level resource 'SourceControl' does not have list by subscription operation, please add it. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L1220
⚠️ RequiredReadOnlySystemData	The response of operation:'GetSourceControl' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L107
⚠️ RequiredReadOnlySystemData	The response of operation:'UpdateSourceControl' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L138
⚠️ PageableOperation	Based on the response model schema, operation 'GetSubscriptionDeploymentLocations' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L305
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'listsitesassignedtohostname' in:'ListSiteIdentifiersAssignedToHostName'. Consider updating the operationId Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L412
⚠️ PageableOperation	Based on the response model schema, operation 'ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L482
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'moveresources' in:'Move'. Consider updating the operationId Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L604
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'validatemoveresources' in:'ValidateMove'. Consider updating the operationId Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L683
⚠️ AllProxyResourcesShouldHaveDelete	The resource SourceControl does not have a corresponding delete operation. Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L1220

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-03T16:30:27Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-web - 7.1.0

-	Model Site no longer has parameter managed_environment_id
-	Model SiteConfig no longer has parameter elastic_web_app_scale_limit
-	Model SiteConfig no longer has parameter ip_security_restrictions_default_action
-	Model SiteConfig no longer has parameter metadata
-	Model SiteConfig no longer has parameter scm_ip_security_restrictions_default_action
-	Model SiteConfigResource no longer has parameter elastic_web_app_scale_limit
-	Model SiteConfigResource no longer has parameter ip_security_restrictions_default_action
-	Model SiteConfigResource no longer has parameter metadata
-	Model SiteConfigResource no longer has parameter scm_ip_security_restrictions_default_action
-	Model StaticSiteARMResource no longer has parameter database_connections
-	Model StaticSiteBuildARMResource no longer has parameter database_connections
-	Model StaticSitePatchResource no longer has parameter database_connections
-	Removed operation StaticSitesOperations.create_or_update_basic_auth
-	Removed operation StaticSitesOperations.create_or_update_build_database_connection
-	Removed operation StaticSitesOperations.create_or_update_database_connection
-	Removed operation StaticSitesOperations.delete_build_database_connection
-	Removed operation StaticSitesOperations.delete_database_connection
-	Removed operation StaticSitesOperations.get_basic_auth
-	Removed operation StaticSitesOperations.get_build_database_connection
-	Removed operation StaticSitesOperations.get_build_database_connection_with_details
-	Removed operation StaticSitesOperations.get_build_database_connections
-	Removed operation StaticSitesOperations.get_build_database_connections_with_details
-	Removed operation StaticSitesOperations.get_database_connection
-	Removed operation StaticSitesOperations.get_database_connection_with_details
-	Removed operation StaticSitesOperations.get_database_connections
-	Removed operation StaticSitesOperations.get_database_connections_with_details
-	Removed operation StaticSitesOperations.list_basic_auth
-	Removed operation StaticSitesOperations.update_build_database_connection
-	Removed operation StaticSitesOperations.update_database_connection
-	Removed operation WebAppsOperations.deploy_workflow_artifacts
-	Removed operation WebAppsOperations.deploy_workflow_artifacts_slot
-	Removed operation WebAppsOperations.get_instance_workflow_slot
-	Removed operation WebAppsOperations.get_workflow
-	Removed operation WebAppsOperations.list_instance_workflows_slot
-	Removed operation WebAppsOperations.list_workflows
-	Removed operation WebAppsOperations.list_workflows_connections
-	Removed operation WebAppsOperations.list_workflows_connections_slot

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.AppService [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-web [View full logs] [Preview SDK Changes]
- azure-mgmt-web-7.1.0.zip
- azure_mgmt_web-7.1.0-py3-none-any.whl
```
info	[Changelog] change log generation failed!!!
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appservice-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appservice/armappservice [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Interface` of struct `WebAppsClientCreateOneDeployOperationResponse` has been removed
info	[Changelog] - Field `Interface` of struct `WebAppsClientGetOneDeployStatusResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `LogLevelDebug`, `LogLevelInfo`, `LogLevelWarn` added to enum type `LogLevel`
info	[Changelog] - New enum type `TLSCipherSuites` with values `TLSCipherSuitesTLSAES128GCMSHA256`, `TLSCipherSuitesTLSAES256GCMSHA384`, `TLSCipherSuitesTLSECDHEECDSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSECDHEECDSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSECDHEECDSAWITHAES256GCMSHA384`, `TLSCipherSuitesTLSECDHERSAWITHAES128CBCSHA`, `TLSCipherSuitesTLSECDHERSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSECDHERSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSECDHERSAWITHAES256CBCSHA`, `TLSCipherSuitesTLSECDHERSAWITHAES256CBCSHA384`, `TLSCipherSuitesTLSECDHERSAWITHAES256GCMSHA384`, `TLSCipherSuitesTLSRSAWITHAES128CBCSHA`, `TLSCipherSuitesTLSRSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSRSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSRSAWITHAES256CBCSHA`, `TLSCipherSuitesTLSRSAWITHAES256CBCSHA256`, `TLSCipherSuitesTLSRSAWITHAES256GCMSHA384`
info	[Changelog] - New function `*ClientFactory.NewGetUsagesInLocationClient() *GetUsagesInLocationClient`
info	[Changelog] - New function `NewGetUsagesInLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GetUsagesInLocationClient, error)`
info	[Changelog] - New function `*GetUsagesInLocationClient.NewListPager(string, string, *GetUsagesInLocationClientListOptions) *runtime.Pager[GetUsagesInLocationClientListResponse]`
info	[Changelog] - New struct `DaprConfig`
info	[Changelog] - New struct `OneDeployRequest`
info	[Changelog] - New field `EnvironmentID` in struct `ResourceNameAvailabilityRequest`
info	[Changelog] - New field `MinTLSCipherSuite` in struct `SiteConfig`
info	[Changelog] - New field `DaprConfig` in struct `SiteProperties`
info	[Changelog] - New field `Request` in struct `WebAppsClientCreateOneDeployOperationOptions`
info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientCreateOneDeployOperationResponse`
info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientGetOneDeployStatusResponse`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 34 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appservice [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-appservice-15.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group GetUsagesInLocation
info	[Changelog]   - Added Interface DaprConfig
info	[Changelog]   - Added Interface GetUsagesInLocationListNextOptionalParams
info	[Changelog]   - Added Interface GetUsagesInLocationListOptionalParams
info	[Changelog]   - Added Interface OneDeployRequest
info	[Changelog]   - Added Type Alias DaprConfigLogLevel
info	[Changelog]   - Added Type Alias GetUsagesInLocationListNextResponse
info	[Changelog]   - Added Type Alias GetUsagesInLocationListResponse
info	[Changelog]   - Added Type Alias TlsCipherSuites
info	[Changelog]   - Interface CheckNameAvailabilityOptionalParams has a new optional parameter environmentId
info	[Changelog]   - Interface ResourceNameAvailabilityRequest has a new optional parameter environmentId
info	[Changelog]   - Interface Site has a new optional parameter daprConfig
info	[Changelog]   - Interface SiteConfig has a new optional parameter minTlsCipherSuite
info	[Changelog]   - Interface SiteConfigResource has a new optional parameter minTlsCipherSuite
info	[Changelog]   - Interface WebAppsCreateOneDeployOperationOptionalParams has a new optional parameter request
info	[Changelog]   - Added Enum KnownDaprConfigLogLevel
info	[Changelog]   - Added Enum KnownTlsCipherSuites
info	[Changelog]   - Added Enum KnownWorkflowState
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class WebSiteManagementClient has a new signature

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from e651b37365076d1bb2d66d2b86a184b03a3f10e4. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.web.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.web.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-03T16:30:28Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appservice/armappservice	https://apiview.dev/Assemblies/Review/10b93be1afe44d598bb51efcc075bac1
Java	azure-resourcemanager-appservice-generated	Create ApiView timeout. Package is too large and we cannot create ApiView for it.
JavaScript	@azure/arm-appservice	https://apiview.dev/Assemblies/Review/66d5af09bca54e38aec8b8d8c974e325

microsoft-github-policy-service · 2023-08-03T16:30:40Z

Thank you for your contribution rohinisharma! We will review the pull request and get back to you soon.

openapi-workflow-bot · 2023-08-03T16:39:55Z

Hi @rohinisharma! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic Validation	Fix-SemanticValidation-Error	High
Model Validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	High

If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

kazrael2119 · 2023-08-22T07:00:05Z

/azp run

openapi-pipeline-app · 2023-08-22T07:00:11Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

azure-pipelines · 2023-08-22T07:00:29Z

Azure Pipelines successfully started running 1 pipeline(s).

kazrael2119 · 2023-08-22T07:19:14Z

this js sdk breaking should be non-breaking

qiaozha · 2023-08-22T08:27:36Z

The JS SDK generation failed, we will need to investigate on this.

kazrael2119 · 2023-08-22T09:28:55Z

your branch is not base on your latest dev-branch: release-web-2023-01-01, please merge latest dev-branch.
and could you help to resolve this issue?#24606 (comment)
this pr was merged with js sdk generation failure. I guess this js sdk generation failure may the same issue after you merge latest dev-branch

openapi-pipeline-app · 2023-08-22T16:14:12Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

rohinisharma · 2023-08-22T16:15:57Z

your branch is not base on your latest dev-branch: release-web-2023-01-01, please merge latest dev-branch. and could you help to resolve this issue?#24606 (comment) this pr was merged with js sdk generation failure. I guess this js sdk generation failure may the same issue after you merge latest dev-branch

I have merged the latest branch in. I am not sure what to do about the JS SDK failure, this was not introduced by my changes was it?

kazrael2119 · 2023-08-23T08:53:25Z

your branch is not base on your latest dev-branch: release-web-2023-01-01, please merge latest dev-branch. and could you help to resolve this issue?#24606 (comment) this pr was merged with js sdk generation failure. I guess this js sdk generation failure may the same issue after you merge latest dev-branch

I have merged the latest branch in. I am not sure what to do about the JS SDK failure, this was not introduced by my changes was it?

can you help fix this issue? or can you ask someone related this change to fix this?

rohinisharma · 2023-08-24T17:24:29Z

your branch is not base on your latest dev-branch: release-web-2023-01-01, please merge latest dev-branch. and could you help to resolve this issue?#24606 (comment) this pr was merged with js sdk generation failure. I guess this js sdk generation failure may the same issue after you merge latest dev-branch

I have merged the latest branch in. I am not sure what to do about the JS SDK failure, this was not introduced by my changes was it?

can you help fix this issue? or can you ask someone related this change to fix this?

@kazrael2119 I have reached out to Sushmitha and she has made a PR to fix this: #25493. Can we get it merged so that this PR can be unblocked?

kazrael2119 · 2023-08-28T07:08:05Z

please merge your dev branch to update make js sdk generation work

rohinisharma · 2023-08-28T18:08:41Z

please merge your dev branch to update make js sdk generation work

@kazrael2119 JS SDK generation has succeeded

kazrael2119 · 2023-08-29T08:14:53Z

this js sdk breaking should be non-breaking

rohinisharma · 2023-08-29T19:07:14Z

/pr RequestMerge

sjanamma

approving for merge

* Add new api-version 2023-01-01 (#22962) * Add new api-version 2023-01-01 * Change default package api-version * Updated workflowstate to be a reference (#23084) * Fix OneDeploy request and response bodies (#23224) * Fix OneDeploy request and response bodies * Fixing typo * Add Container Apps Environment Id in checknameavailability API (#24102) Co-authored-by: Vishal Gupta <[email protected]> * Add minTlsCipherSuite property (#24198) * Add minTlsCipherSuite property * Move to SiteConfig --------- Co-authored-by: Chris Rosenblatt <[email protected]> * Dapr configuration for a site (#24606) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Fix for JS SDK check failure for Dapr Config (#25493) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail * JS Sdk check fail fix --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Release web 2023 01 01 (#25157) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments --------- Co-authored-by: Rohini Sharma <[email protected]> * Release web 2023 01 01 (#25629) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments * Removing quota type parameter --------- Co-authored-by: Rohini Sharma <[email protected]> * Adding workload profile & resource config to Site (#25868) * Adding workload profile & resource config to Site * prettier fix * cosmetic fix * updating examples * prettier fix * Fix Python SDK failure for Dapr log level config (#26198) * Rename log level enum for dapr * Fix Python SDK failure for Dapr log level config * Rename log level num for dapr (#26374) * Rename log level num for dapr * Rename log level num for dapr * initial change to add ase regions (#26333) * initial change to add ase regions * addressing comments * nit adding example as suggested * formatting code * add custom word * prettier everything * prettier everything * Revert "Fix OneDeploy request and response bodies (#23224)" (#26580) This reverts commit 7dfc303. --------- Co-authored-by: Alex Karcher <[email protected]> Co-authored-by: dannysongg <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: SushmithaVReddy <[email protected]> Co-authored-by: Sushmitha Vangala <[email protected]> Co-authored-by: rohinisharma <[email protected]> Co-authored-by: Rohini Sharma <[email protected]> Co-authored-by: mukundnigam <[email protected]> Co-authored-by: Kirstyn Amperiadis <[email protected]> Co-authored-by: Haochi <[email protected]>

Rohini Sharma added 12 commits April 13, 2023 10:05

Adding locations/usages endpoint and example

4a11107

Revert "Adding locations/usages endpoint and example"

f87f156

This reverts commit 4a11107.

Adding back usages changes with up to date branch

40197ca

Updates based on verification tools

7ed8c3a

Fixing spacing, adding missing comma

a4e8765

ran prettier-fix for formatting

272be5d

Update for new QMS requirements with ZR

a5245a6

Using prettier to fix linter error

aa78c8e

Adding ZR endpoint

9c412bd

Fixing duplicate operationId

eb7b549

Merge branch 'release-web-2023-01-01' of github.com:rohinisharma/azur…

3d1b666

…e-rest-api-specs into release-web-2023-01-01

QMS Usages

e6211ca

rohinisharma requested a review from naveedaz as a code owner August 3, 2023 16:30

openapi-assignment-bot bot assigned rkmanda Aug 3, 2023

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 3, 2023

azure-sdk mentioned this pull request Aug 3, 2023

[AutoPR sdk/resourcemanager/appservice/armappservice] Release web 2023 01 01 azure-sdk/azure-sdk-for-go#6686

Closed

AzureRestAPISpecReview added ARMReview CI-FixRequiredOnFailure resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 3, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 3, 2023

qiaozha added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 22, 2023

Merge branch 'Azure:release-web-2023-01-01' into release-web-2023-01-01

cf9e46a

rohinisharma added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2023

openapi-workflow-bot bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 22, 2023

ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 23, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 23, 2023

Merge branch 'Azure:release-web-2023-01-01' into release-web-2023-01-01

5ba3db2

qiaozha added the Approved-SdkBreakingChange-JavaScript label Aug 29, 2023

rohinisharma removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 29, 2023

github-actions bot added the MergeRequested label Aug 29, 2023

sjanamma approved these changes Aug 29, 2023

View reviewed changes

sjanamma merged commit c058c9c into Azure:release-web-2023-01-01 Aug 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release web 2023 01 01 #25157

Release web 2023 01 01 #25157

rohinisharma commented Aug 3, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 3, 2023

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

microsoft-github-policy-service bot commented Aug 3, 2023

openapi-workflow-bot bot commented Aug 3, 2023

kazrael2119 commented Aug 22, 2023

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

azure-pipelines bot commented Aug 22, 2023

kazrael2119 commented Aug 22, 2023 •

edited

Loading

qiaozha commented Aug 22, 2023

kazrael2119 commented Aug 22, 2023

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

rohinisharma commented Aug 22, 2023

kazrael2119 commented Aug 23, 2023

rohinisharma commented Aug 24, 2023

kazrael2119 commented Aug 28, 2023

rohinisharma commented Aug 28, 2023

kazrael2119 commented Aug 29, 2023

rohinisharma commented Aug 29, 2023

sjanamma left a comment

Release web 2023 01 01 #25157

Release web 2023 01 01 #25157

Conversation

rohinisharma commented Aug 3, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Getting help

openapi-workflow-bot bot commented Aug 3, 2023

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Generated ApiView

microsoft-github-policy-service bot commented Aug 3, 2023

openapi-workflow-bot bot commented Aug 3, 2023

kazrael2119 commented Aug 22, 2023

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

azure-pipelines bot commented Aug 22, 2023

kazrael2119 commented Aug 22, 2023 • edited Loading

qiaozha commented Aug 22, 2023

kazrael2119 commented Aug 22, 2023

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

rohinisharma commented Aug 22, 2023

kazrael2119 commented Aug 23, 2023

rohinisharma commented Aug 24, 2023

kazrael2119 commented Aug 28, 2023

rohinisharma commented Aug 28, 2023

kazrael2119 commented Aug 29, 2023

rohinisharma commented Aug 29, 2023

sjanamma left a comment

Choose a reason for hiding this comment

rohinisharma commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

kazrael2119 commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading