Adding workload profile & resource config to Site #25868

mukundnigam · 2023-09-20T04:47:22Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-09-20T04:47:25Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-09-20T04:47:25Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
CommonDefinitions.json	2023-01-01(48bcb68)	2022-09-01(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.5)	new version	base version
package-2023-01	package-2023-01(48bcb68)	package-2023-01(release-web-2023-01-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Recommendations_ListRecommendedRulesForHostingEnvironment' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByHostingEnvironment' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'Recommendations_ListRecommendedRulesForWebApp' does not match the response definition in the individual GET operation 'Recommendations_GetRuleDetailsByWebApp' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'WebApps_ListRelayServiceConnections' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnection' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'WebApps_ListRelayServiceConnectionsSlot' does not match the response definition in the individual GET operation 'WebApps_GetRelayServiceConnectionSlot' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'WebApps_ListPremierAddOns' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOn' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` GetCollectionResponseSchema	The response in the GET collection operation 'WebApps_ListPremierAddOnsSlot' does not match the response definition in the individual GET operation 'WebApps_GetPremierAddOnSlot' . Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L17
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L229
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L408
`❌` GuidUsage	Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L671
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L700
`❌` ProvisioningStateValidation	ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L968
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1011
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1115
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1390
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1416
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1787
`❌` NestedResourcesMustHaveListOperation	The nested resource 'HybridConnection' does not have list operation, please add it. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1806
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1965
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L1984
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2070
`❌` GuidUsage	Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2239
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2672
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2720
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2720
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2741
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2745
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2793
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2918
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2918
`❌` PropertiesTypeObjectNoDefinition	Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience. Location: Microsoft.Web/stable/2023-01-01/CommonDefinitions.json#L2918

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-20T04:47:26Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.AppService [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-web [View full logs] [Preview SDK Changes]
- azure-mgmt-web-7.1.0.zip
- azure_mgmt_web-7.1.0-py3-none-any.whl
```
info	[Changelog] change log generation failed!!!
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appservice-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appservice/armappservice [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Interface` of struct `WebAppsClientCreateOneDeployOperationResponse` has been removed
info	[Changelog] - Field `Interface` of struct `WebAppsClientGetOneDeployStatusResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `LogLevelDebug`, `LogLevelInfo`, `LogLevelWarn` added to enum type `LogLevel`
info	[Changelog] - New enum type `TLSCipherSuites` with values `TLSCipherSuitesTLSAES128GCMSHA256`, `TLSCipherSuitesTLSAES256GCMSHA384`, `TLSCipherSuitesTLSECDHEECDSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSECDHEECDSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSECDHEECDSAWITHAES256GCMSHA384`, `TLSCipherSuitesTLSECDHERSAWITHAES128CBCSHA`, `TLSCipherSuitesTLSECDHERSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSECDHERSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSECDHERSAWITHAES256CBCSHA`, `TLSCipherSuitesTLSECDHERSAWITHAES256CBCSHA384`, `TLSCipherSuitesTLSECDHERSAWITHAES256GCMSHA384`, `TLSCipherSuitesTLSRSAWITHAES128CBCSHA`, `TLSCipherSuitesTLSRSAWITHAES128CBCSHA256`, `TLSCipherSuitesTLSRSAWITHAES128GCMSHA256`, `TLSCipherSuitesTLSRSAWITHAES256CBCSHA`, `TLSCipherSuitesTLSRSAWITHAES256CBCSHA256`, `TLSCipherSuitesTLSRSAWITHAES256GCMSHA384`
info	[Changelog] - New function `*ClientFactory.NewGetUsagesInLocationClient() *GetUsagesInLocationClient`
info	[Changelog] - New function `NewGetUsagesInLocationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*GetUsagesInLocationClient, error)`
info	[Changelog] - New function `*GetUsagesInLocationClient.NewListPager(string, *GetUsagesInLocationClientListOptions) *runtime.Pager[GetUsagesInLocationClientListResponse]`
info	[Changelog] - New struct `DaprConfig`
info	[Changelog] - New struct `OneDeployRequest`
info	[Changelog] - New struct `ResourceConfig`
info	[Changelog] - New field `EnvironmentID` in struct `ResourceNameAvailabilityRequest`
info	[Changelog] - New field `MinTLSCipherSuite` in struct `SiteConfig`
info	[Changelog] - New field `DaprConfig`, `ResourceConfig`, `WorkloadProfileName` in struct `SiteProperties`
info	[Changelog] - New field `Request` in struct `WebAppsClientCreateOneDeployOperationOptions`
info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientCreateOneDeployOperationResponse`
info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientGetOneDeployStatusResponse`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 36 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appservice [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-appservice-15.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group GetUsagesInLocation
info	[Changelog]   - Added Interface DaprConfig
info	[Changelog]   - Added Interface GetUsagesInLocationListNextOptionalParams
info	[Changelog]   - Added Interface GetUsagesInLocationListOptionalParams
info	[Changelog]   - Added Interface OneDeployRequest
info	[Changelog]   - Added Interface ResourceConfig
info	[Changelog]   - Added Type Alias DaprConfigLogLevel
info	[Changelog]   - Added Type Alias GetUsagesInLocationListNextResponse
info	[Changelog]   - Added Type Alias GetUsagesInLocationListResponse
info	[Changelog]   - Added Type Alias TlsCipherSuites
info	[Changelog]   - Interface CheckNameAvailabilityOptionalParams has a new optional parameter environmentId
info	[Changelog]   - Interface ResourceNameAvailabilityRequest has a new optional parameter environmentId
info	[Changelog]   - Interface Site has a new optional parameter daprConfig
info	[Changelog]   - Interface Site has a new optional parameter resourceConfig
info	[Changelog]   - Interface Site has a new optional parameter workloadProfileName
info	[Changelog]   - Interface SiteConfig has a new optional parameter minTlsCipherSuite
info	[Changelog]   - Interface SiteConfigResource has a new optional parameter minTlsCipherSuite
info	[Changelog]   - Interface WebAppsCreateOneDeployOperationOptionalParams has a new optional parameter request
info	[Changelog]   - Added Enum KnownDaprConfigLogLevel
info	[Changelog]   - Added Enum KnownTlsCipherSuites
info	[Changelog]   - Added Enum KnownWorkflowState
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class WebSiteManagementClient has a new signature

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from e0f81b8ce062b9919144863af57993124f11f29b. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.web.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.web.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-09-20T04:47:27Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appservice/armappservice	https://apiview.dev/Assemblies/Review/f1a2663fd98e40ba8cf8d4cbd0a6ef97
Java	azure-resourcemanager-appservice-generated	https://apiview.dev/Assemblies/Review/8a7685c394ca4f3bbb45a13ba089df27
JavaScript	@azure/arm-appservice	https://apiview.dev/Assemblies/Review/96cbebff11ce475491f8c643796a1660

kazrael2119 · 2023-09-22T01:49:37Z

/azp run

azure-pipelines · 2023-09-22T01:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

sanar-microsoft · 2023-09-22T04:58:33Z

/azp run

azure-pipelines · 2023-09-22T04:58:43Z

Azure Pipelines successfully started running 1 pipeline(s).

sanar-microsoft · 2023-09-22T08:25:08Z

specification/web/resource-manager/Microsoft.Web/stable/2023-01-01/CommonDefinitions.json

@@ -2923,6 +2923,14 @@
              "$ref": "#/definitions/DaprConfig",
              "description": "Dapr configuration of the app."
            },
+            "workloadProfileName": {


Are there example updates?

This PR is in release branch and was looking into few of the previous PRs which do not have the examples updates for properties used on a specific scenario. These properties are applicable for one of the scenarios in this Site schema (Site schema have multiple scenarios of Web, functions, logic app, etc where this is not applicable), so may not be also accurate to update.

e.g.
Dapr configuration for a site by SushmithaVReddy · Pull Request #24606 · Azure/azure-rest-api-specs (github.com)
WebRp || Added environmentId in Site by vishal1997 · Pull Request #25173 · Azure/azure-rest-api-specs (github.com)
Add Container Apps Environment Id in checknameavailability API by vishal1997 · Pull Request #24102 · Azure/azure-rest-api-specs (github.com)
#22341

Since these properties are for external customers and these examples are feed into public rest api doc that customer follows, it is always good to add examples for all the properties, so that Cx can get idea how the property values look like. From your explanation, it is not clear what is the concern here adding/updating the examples for the new properties added in this PR.
I would suggest consider adding them in your examples.

live1206 · 2023-09-25T02:46:23Z

@mukundnigam
The .NET track 2 SDK automation failed due to naming conflicts, and it is failing in the target release branch as well, not caused by the current PR.
We can handle it by renaming while generate .NET track 2 SDK.

openapi-workflow-bot · 2023-09-25T13:13:52Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

mukundnigam · 2023-10-04T11:10:52Z

/pr RequestMerge

* Add new api-version 2023-01-01 (#22962) * Add new api-version 2023-01-01 * Change default package api-version * Updated workflowstate to be a reference (#23084) * Fix OneDeploy request and response bodies (#23224) * Fix OneDeploy request and response bodies * Fixing typo * Add Container Apps Environment Id in checknameavailability API (#24102) Co-authored-by: Vishal Gupta <[email protected]> * Add minTlsCipherSuite property (#24198) * Add minTlsCipherSuite property * Move to SiteConfig --------- Co-authored-by: Chris Rosenblatt <[email protected]> * Dapr configuration for a site (#24606) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Fix for JS SDK check failure for Dapr Config (#25493) * Dapr configuration for a site * removed dapr older definition * adding back old dapr definition * Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition * to initiate checks as re-run * fixed prettier check fail * JS Sdk check fail fix --------- Co-authored-by: Sushmitha Vangala <[email protected]> * Release web 2023 01 01 (#25157) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments --------- Co-authored-by: Rohini Sharma <[email protected]> * Release web 2023 01 01 (#25629) * Adding locations/usages endpoint and example * Revert "Adding locations/usages endpoint and example" This reverts commit 4a11107. * Adding back usages changes with up to date branch * Updates based on verification tools * Fixing spacing, adding missing comma * ran prettier-fix for formatting * Update for new QMS requirements with ZR * Using prettier to fix linter error * Adding ZR endpoint * Fixing duplicate operationId * QMS Usages * Validation changes * Updating schema * Updating for collection * fixing pr comments * Resolving comments * Updating description * Resolving comments * Removing quota type parameter --------- Co-authored-by: Rohini Sharma <[email protected]> * Adding workload profile & resource config to Site (#25868) * Adding workload profile & resource config to Site * prettier fix * cosmetic fix * updating examples * prettier fix * Fix Python SDK failure for Dapr log level config (#26198) * Rename log level enum for dapr * Fix Python SDK failure for Dapr log level config * Rename log level num for dapr (#26374) * Rename log level num for dapr * Rename log level num for dapr * initial change to add ase regions (#26333) * initial change to add ase regions * addressing comments * nit adding example as suggested * formatting code * add custom word * prettier everything * prettier everything * Revert "Fix OneDeploy request and response bodies (#23224)" (#26580) This reverts commit 7dfc303. --------- Co-authored-by: Alex Karcher <[email protected]> Co-authored-by: dannysongg <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Vishal Gupta <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: Chris Rosenblatt <[email protected]> Co-authored-by: SushmithaVReddy <[email protected]> Co-authored-by: Sushmitha Vangala <[email protected]> Co-authored-by: rohinisharma <[email protected]> Co-authored-by: Rohini Sharma <[email protected]> Co-authored-by: mukundnigam <[email protected]> Co-authored-by: Kirstyn Amperiadis <[email protected]> Co-authored-by: Haochi <[email protected]>

Adding workload profile & resource config to Site

329d926

mukundnigam requested a review from naveedaz as a code owner September 20, 2023 04:47

openapi-assignment-bot bot assigned rkmanda Sep 20, 2023

mukundnigam added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Sep 20, 2023

azure-sdk mentioned this pull request Sep 20, 2023

[AutoPR sdk/resourcemanager/appservice/armappservice] Adding workload profile & resource config to Site azure-sdk/azure-sdk-for-go#7327

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 20, 2023

mukundnigam closed this Sep 20, 2023

mukundnigam reopened this Sep 20, 2023

prettier fix

4374b6a

azure-sdk mentioned this pull request Sep 20, 2023

[AutoPR track2_azure-mgmt-web] Adding workload profile & resource config to Site azure-sdk/azure-sdk-for-python#4706

Closed

mukundnigam added IDCDevDiv and removed NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR labels Sep 20, 2023

cosmetic fix

3f4f4d3

openapi-pipeline-app bot added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Sep 21, 2023

mukundnigam removed the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Sep 21, 2023

openapi-pipeline-app bot added NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR and removed NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR labels Sep 22, 2023

sanar-microsoft reviewed Sep 22, 2023

View reviewed changes

samsaha-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 25, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2023

mukundnigam added 2 commits September 27, 2023 11:21

updating examples

e4a436b

prettier fix

48bcb68

mukundnigam force-pushed the munigam_localchange branch from 53963e2 to 48bcb68 Compare September 27, 2023 06:54

mukundnigam removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 27, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2023

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 27, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2023

naveedaz approved these changes Oct 3, 2023

View reviewed changes

github-actions bot added the MergeRequested label Oct 4, 2023

sjanamma merged commit 8450c7d into Azure:release-web-2023-01-01 Oct 5, 2023
22 of 26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding workload profile & resource config to Site #25868

Adding workload profile & resource config to Site #25868

mukundnigam commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

kazrael2119 commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

sanar-microsoft commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

sanar-microsoft Sep 22, 2023

mukundnigam Sep 22, 2023 •

edited

Loading

samsaha-ms Sep 25, 2023

live1206 commented Sep 25, 2023

openapi-workflow-bot bot commented Sep 25, 2023

mukundnigam commented Oct 4, 2023

Adding workload profile & resource config to Site #25868

Adding workload profile & resource config to Site #25868

Conversation

mukundnigam commented Sep 20, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Sep 20, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 20, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Sep 20, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Sep 20, 2023 • edited Loading

Generated ApiView

kazrael2119 commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

sanar-microsoft commented Sep 22, 2023

azure-pipelines bot commented Sep 22, 2023

sanar-microsoft Sep 22, 2023

Choose a reason for hiding this comment

mukundnigam Sep 22, 2023 • edited Loading

Choose a reason for hiding this comment

samsaha-ms Sep 25, 2023

Choose a reason for hiding this comment

live1206 commented Sep 25, 2023

openapi-workflow-bot bot commented Sep 25, 2023

mukundnigam commented Oct 4, 2023

mukundnigam commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

openapi-pipeline-app bot commented Sep 20, 2023 •

edited

Loading

mukundnigam Sep 22, 2023 •

edited

Loading