Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlvirtualmachine - enum in AgReplica Is In Wrong Case #22768

Closed
myc2h6o opened this issue Feb 23, 2023 · 2 comments · Fixed by #22799
Closed

sqlvirtualmachine - enum in AgReplica Is In Wrong Case #22768

myc2h6o opened this issue Feb 23, 2023 · 2 comments · Fixed by #22799
Assignees
@navba-MSFT
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. SQL - VM

Comments

@myc2h6o
Copy link

myc2h6o commented Feb 23, 2023

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

Ref:

azure-rest-api-specs/specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json

Lines 1115 to 1128 in 8468620

"AgReplica": {
"description": "Availability group replica configuration.",
"type": "object",
"properties": {
"sqlVirtualMachineInstanceId": {
"description": "Sql VirtualMachine Instance Id.",
"type": "string"
},
"role": {
"description": "Replica Role in availability group.",
"enum": [
"PRIMARY",
"SECONDARY"
],

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 23, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 27, 2023
@navba-MSFT navba-MSFT self-assigned this Feb 27, 2023
@navba-MSFT
Copy link
Contributor

@myc2h6o Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

navba-MSFT added a commit that referenced this issue Feb 27, 2023
@navba-MSFT
{AzureSQLVM} fixes #22768 Fix the enums under AgReplica
25a6ac1 
fixes #22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica
@navba-MSFT navba-MSFT mentioned this issue Feb 27, 2023
Merged
11 tasks
@myc2h6o
Copy link
Author

myc2h6o commented Feb 27, 2023

Hi @navba-MSFT thanks for the quick fix! the readableSecondary property has the similar issue as well during my test. It is set to All at service side instead of ALL from swagger

@navba-MSFT navba-MSFT added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 2, 2023
changlong-liu pushed a commit that referenced this issue Mar 2, 2023
@navba-MSFT
{AzureSQLVM} fixes #22768 Fix the enums under AgReplica (#22799)
8335066 
* {AzureSQLVM} fixes #22768 Fix the enums under AgReplica

fixes #22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-resource-manager-schemas that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
725065f 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-go that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
b383e1f 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
a4a33d4 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
1fa2e59 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-powershell that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
e0f5850 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Mar 2, 2023
CodeGen from PR 22799 in Azure/azure-rest-api-specs
1507276 
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this issue Mar 22, 2023
@navba-MSFT @aviyerMSFT
{AzureSQLVM} fixes Azure#22768 Fix the enums under AgReplica (Azure#2…
c0b45df 
…2799)

* {AzureSQLVM} fixes Azure#22768 Fix the enums under AgReplica

fixes Azure#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navba-MSFT navba-MSFT

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. SQL - VM
Projects
None yet
Milestone
No milestone
3 participants
@myc2h6o @JackTn @navba-MSFT