Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica #22799

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

navba-MSFT
Copy link
Contributor

@navba-MSFT navba-MSFT commented Feb 27, 2023

fixes #22768

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit Similar issue happens for other properties in AgReplica.

Also the readableSecondary property has the similar issue as well during my test. It is set to All at service side instead of ALL from swagger

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

fixes #22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica
@openapi-workflow-bot
Copy link

Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 27, 2023

    Swagger Validation Report

    ️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    sqlvm.json 2022-02-01(c6cfcca) 2022-02-01(main)
    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) 'PRIMARY, SECONDARY' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1123:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1123:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'SYNCHRONOUS_COMMIT, ASYNCHRONOUS_COMMIT' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1135:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1135:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'AUTOMATIC, MANUAL' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1147:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1147:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'NO, ALL, READ_ONLY' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1159:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1159:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'Primary, Secondary' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1123:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1123:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'Synchronous_Commit, Asynchronous_Commit' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1135:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1135:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'Automatic, Manual' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1147:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1147:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'No, All, Read_Only' from the old version.
    New: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1159:9
    Old: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1159:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-02 package-2022-02(c6cfcca) package-2022-02(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L19
    ResourceNameRestriction The resource name parameter 'availabilityGroupListenerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L19
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L75
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L142
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L180
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L195
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.SqlVirtualMachine/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L256
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L274
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L316
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L373
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L404
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L451
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L545
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L627
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L748
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L779
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L810
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L826
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L884
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L885
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L916
    ResourceNameRestriction The resource name parameter 'sqlVirtualMachineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L928
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L929
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L960
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L987
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1227
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1578
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L1596
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AvailabilityGroupListeners_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L75
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 32 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L20:14
    ExampleUrl: stable/2022-02-01/examples/GetAvailabilityGroupListener.json#L2:17
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: api-version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L2298:28
    ExampleUrl: stable/2022-02-01/examples/GetAvailabilityGroupListener.json#L7:20
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L75:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateAvailabilityGroupListener.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L75:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateAvailabilityGroupListenerWithMultiSubnet.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L142:17
    ExampleUrl: stable/2022-02-01/examples/DeleteAvailabilityGroupListener.json#L2:17
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L173:22
    ExampleUrl: stable/2022-02-01/examples/DeleteAvailabilityGroupListener.json
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L196:14
    ExampleUrl: stable/2022-02-01/examples/ListByGroupAvailabilityGroupListener.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2021-11-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L242:14
    ExampleUrl: stable/2022-02-01/examples/ListOperation.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L275:14
    ExampleUrl: stable/2022-02-01/examples/GetSqlVirtualMachineGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L316:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L373:17
    ExampleUrl: stable/2022-02-01/examples/DeleteSqlVirtualMachineGroup.json#L2:17
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L397:22
    ExampleUrl: stable/2022-02-01/examples/DeleteSqlVirtualMachineGroup.json
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L418:16
    ExampleUrl: stable/2022-02-01/examples/UpdateSqlVirtualMachineGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L471:14
    ExampleUrl: stable/2022-02-01/examples/ListByResourceGroupSqlVirtualMachineGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L510:14
    ExampleUrl: stable/2022-02-01/examples/ListSubscriptionSqlVirtualMachineGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L546:14
    ExampleUrl: stable/2022-02-01/examples/ListBySqlVirtualMachineGroupSqlVirtualMachine.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L592:14
    ExampleUrl: stable/2022-02-01/examples/ListSubscriptionSqlVirtualMachine.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L628:14
    ExampleUrl: stable/2022-02-01/examples/GetSqlVirtualMachine.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineMIN.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineMAX.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateVirtualMachineWithVMGroup.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineStorageConfigurationNEW.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineStorageConfigurationEXTEND.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L676:14
    ExampleUrl: stable/2022-02-01/examples/CreateOrUpdateSqlVirtualMachineAutomatedBackupWeekly.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L748:17
    ExampleUrl: stable/2022-02-01/examples/DeleteSqlVirtualMachine.json#L2:17
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L772:22
    ExampleUrl: stable/2022-02-01/examples/DeleteSqlVirtualMachine.json
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L793:16
    ExampleUrl: stable/2022-02-01/examples/UpdateSqlVirtualMachine.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2022-02-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L846:14
    ExampleUrl: stable/2022-02-01/examples/ListByResourceGroupSqlVirtualMachine.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2021-11-01-preview is not equal to swagger version
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L885:15
    ExampleUrl: stable/2022-02-01/examples/RedeploySqlVirtualMachine.json#L2:17
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.SqlVirtualMachine/stable/2022-02-01/sqlvm.json#L909:22
    ExampleUrl: stable/2022-02-01/examples/RedeploySqlVirtualMachine.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 27, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8335066. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.3.1 -> 9.5.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-sqlvirtualmachine [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8335066. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `LeastPrivilegeModeNotSet` added to type alias `LeastPrivilegeMode`
      info	[Changelog] - New type alias `TroubleshootingScenario` with values `TroubleshootingScenarioUnhealthyReplica`
      info	[Changelog] - New function `NewTroubleshootClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TroubleshootClient, error)`
      info	[Changelog] - New function `*TroubleshootClient.BeginTroubleshoot(context.Context, string, string, SQLVMTroubleshooting, *TroubleshootClientBeginTroubleshootOptions) (*runtime.Poller[TroubleshootClientTroubleshootResponse], error)`
      info	[Changelog] - New struct `AADAuthenticationSettings`
      info	[Changelog] - New struct `SQLVMTroubleshooting`
      info	[Changelog] - New struct `TroubleshootClient`
      info	[Changelog] - New struct `TroubleshootingAdditionalProperties`
      info	[Changelog] - New struct `TroubleshootingStatus`
      info	[Changelog] - New struct `UnhealthyReplicaInfo`
      info	[Changelog] - New field `TroubleshootingStatus` in struct `Properties`
      info	[Changelog] - New field `AzureAdAuthenticationSettings` in struct `ServerConfigurationsManagementSettings`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 19 additive change(s).
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8335066. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️sqlvirtualmachine [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 8335066. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.sqlvirtualmachine [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 27, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine https://apiview.dev/Assemblies/Review/9c42b75de8004d3fa8bc644fe3210717
    Java azure-resourcemanager-sqlvirtualmachine https://apiview.dev/Assemblies/Review/67b91bca55984dc08d5e42b187e07498
    .Net Azure.ResourceManager.SqlVirtualMachine https://apiview.dev/Assemblies/Review/5fbf9fe236c7469d922f15d8d6e908c7

    @openapi-workflow-bot
    Copy link

    Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    …2799)
    
    * {AzureSQLVM} fixes Azure#22768 Fix the enums under AgReplica
    
    fixes Azure#22768 
    
    The casing seems not correct in Swagger compared to Service.
    
    e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
    Similar issue happens for other properties in AgReplica
    
    * Update sqlvm.json
    
    * Update sqlvm.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    sqlvirtualmachine - enum in AgReplica Is In Wrong Case
    5 participants