-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica #22799
Conversation
fixes #22768 The casing seems not correct in Swagger compared to Service. e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit Similar issue happens for other properties in AgReplica
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
…2799) * {AzureSQLVM} fixes Azure#22768 Fix the enums under AgReplica fixes Azure#22768 The casing seems not correct in Swagger compared to Service. e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit Similar issue happens for other properties in AgReplica * Update sqlvm.json * Update sqlvm.json
fixes #22768
The casing seems not correct in Swagger compared to Service.
e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit Similar issue happens for other properties in
AgReplica
.Also the
readableSecondary
property has the similar issue as well during my test. It is set to All at service side instead of ALL from swaggerARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.