Always return dictionary from tests #22799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
requested review from
kashifkhan,
tjprescott,
catalinaperalta,
xiangyan99 and
scbedd
catalinaperalta
approved these changes
Jan 27, 2022
tjprescott
reviewed
Jan 27, 2022
tools/azure-sdk-tools/devtools_testutils/aio/proxy_testcase_async.py
Outdated
Show resolved
Hide resolved
tjprescott
approved these changes
Jan 27, 2022
|
/check-enforcer override |
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Mar 2, 2023
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)
* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica
fixes Azure/azure-rest-api-specs#22768
The casing seems not correct in Swagger compared to Service.
e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica
* Update sqlvm.json
* Update sqlvm.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #22787. This is a patch-up for a bug discovered by @tjprescott. After the recent change to put
"x-recording-file"in the body of recording start requests, tests have stopped producing recordings whenever they don't return a dictionary. Returning anything in a test should only be necessary for tests using thevariablesAPI.While I work on a second, more user-friendly iteration of the
variablesAPI (and track down the code that produced this bug in the test proxy tool), this change will make it unnecessary for every test to return a dictionary in order to record.Tagging those affected by the bug and @scbedd for notifs.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines