Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestProxy] tests should not have to return variables to record #22787

Closed
tjprescott opened this issue Jan 26, 2022 · 0 comments · Fixed by #22799
Closed

[TestProxy] tests should not have to return variables to record #22787

tjprescott opened this issue Jan 26, 2022 · 0 comments · Fixed by #22799
Assignees
@mccoyp
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. test-reliability Issue that causes tests to be unreliable

Comments

@tjprescott
Copy link
Member

Discovered in #22187, when a tests uses @recorded_by_proxy but does not return anything (because it does not use the variables API), no recording is produced.

Tests should NOT have to return anything in order to be recorded. Per #22275, even using the variables API should not require a return statement.
@tjprescott tjprescott added bug This issue requires a change to an existing behavior in the product in order to be resolved. test-reliability Issue that causes tests to be unreliable labels Jan 26, 2022
@mccoyp mccoyp mentioned this issue Jan 27, 2022
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always return dictionary from tests mccoyp/azure-sdk-for-python
2 participants
@tjprescott @mccoyp