Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Enable test-proxy and test-resources.bicep #22187

Merged
merged 33 commits into from
Jan 31, 2022
Merged

[Search] Enable test-proxy and test-resources.bicep #22187

merged 33 commits into from
Jan 31, 2022

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Dec 15, 2021 •
edited
Loading

Fixes #21493. Fixes #20692.

Regular

  • test_search_client_basic_live
  • test_search_client_buffered_sender_live
  • test_search_client_index_document_live
  • test_search_client_search_live
  • test_search_client_data_source_live
  • test_search_index_client_live
  • test_search_index_client_skillset_live
  • test_search_index_client_synonym_map_live
  • test_search_indexer_client_live

Async

  • test_search_client_basic_live_async
  • test_search_client_buffered_sender_live_async
  • test_search_client_index_document_live_async
  • test_search_client_search_live_async
  • test_search_client_data_source_live_async
  • test_search_index_client_live_async
  • test_search_index_client_skillset_live_async
  • test_search_index_client_synonym_map_live_asycn
  • test_search_indexer_client_live_async

@ghost ghost added the Search label Dec 15, 2021
@tjprescott tjprescott mentioned this pull request Dec 15, 2021
Closed
@tjprescott tjprescott marked this pull request as draft December 15, 2021 20:05
@tjprescott tjprescott mentioned this pull request Dec 29, 2021
Closed
@tjprescott
Copy link
Member Author

tjprescott commented Jan 3, 2022 •
edited
Loading

Blocked by issue #22387.
Fixed!

@check-enforcer
Copy link

check-enforcer bot commented Jan 7, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@tjprescott
Copy link
Member Author

Some tests had to be disabled because the service is failing for them, even on the main (unconverted) branch. See: #22769

@tjprescott tjprescott mentioned this pull request Jan 26, 2022
Closed
@tjprescott tjprescott marked this pull request as ready for review January 27, 2022 22:56
@tjprescott
Copy link
Member Author

@kashifkhan @mccoyp @xiangyan99 all tests have been converted and successfully record. This PR is ready for review!!

@tjprescott
Recording updates.
815315c
@tjprescott
test_search_index_client_data_source_live.py
0076369
@tjprescott
test_search_client_search_live.py
b542f29
@tjprescott
Workaround for Python recording bug.
ab7f533
@tjprescott
test_search_client_index_document_live.py
cf46397
@tjprescott
test_search_client_buffered_sender_live.py
c0f39f3
@tjprescott
test_search_client_basic_live_async.py
8feb67a
@tjprescott
test_serach_client_search_live_async.py
bcc186a
@tjprescott
test_search_index_client_live_async.py
bc2314e
@tjprescott
test_search_index_client_synonym_map_live_async.py
a4a1407
@tjprescott
test_search_index_client_skillset_live_async.py
2e45fb3
@tjprescott
test_search_index_client_data_source_live.py
4cf0fa6
@tjprescott
Remove workaround annotations.
23bca69
@tjprescott
test_search_client_index_document_live_async.py
425aa51
@tjprescott
test_search_client_buffered_sender_live_async.py
a371a05
@tjprescott
Re-record and finalize all tests.
939710b
@tjprescott
Ignore cSpell
775a249
@tjprescott
Goodbye PowershellPreparer
1588c28
@kashifkhan kashifkhan self-requested a review January 31, 2022 18:53
kashifkhan
kashifkhan approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@kashifkhan kashifkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tjprescott tjprescott merged commit 26d2205 into Azure:main Jan 31, 2022
@tjprescott tjprescott deleted the tjprescott/SearchMQ branch January 31, 2022 19:21
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@tjprescott @rakshith91
[Search] Enable test-proxy and test-resources.bicep (Azure#22187)
178ca4c 
* Add test-resources.bicep

* Test-proxy configuration.

* Convert test_search_indexer_client_live.py

* Update test to use variables.

* Fix Azure#22187.

* Commit first successful recordings!

* Synonym map progress.

* Convert test_search_index_client_synonym_map_live.py

* Fix imports for CI.

* Parameterized search_decorator.

* FINALLY get parameterized test working.... ..............................................

* Fix up tests.

* Progress

* Finalize skillset tests. Remove old recordings and legacy code.

* search_index_client_live.py

* Recording updates.

* test_search_index_client_data_source_live.py

* test_search_client_search_live.py

* Workaround for Python recording bug.

* test_search_client_index_document_live.py

* test_search_client_buffered_sender_live.py

* test_search_client_basic_live_async.py

* test_serach_client_search_live_async.py

* test_search_index_client_live_async.py

* test_search_index_client_synonym_map_live_async.py

* test_search_index_client_skillset_live_async.py

* test_search_index_client_data_source_live.py

* Remove workaround annotations.

* test_search_client_index_document_live_async.py

* test_search_client_buffered_sender_live_async.py

* Re-record and finalize all tests.

* Ignore cSpell

* Goodbye PowershellPreparer
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jan 17, 2023
CodeGen from PR 22187 in Azure/azure-rest-api-specs
4216dcd 
add or modify files (Azure#22187)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifkhan kashifkhan kashifkhan approved these changes

@mccoyp mccoyp Awaiting requested review from mccoyp

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

Assignees
No one assigned
Labels
Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] Update Search to use Test Proxy server [Search] Test reliability issues with azure-search-documents
2 participants
@tjprescott @kashifkhan