Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recorded data usage in FormRecognizer tests infrastructure #22799

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Jul 7, 2021

Ref - #21633

  • Updated test infrastructure to remove dependency on recorded data
  • Re-record recordings

Closes - #21633

@samvaity samvaity requested a review from mssfang July 7, 2021 07:25
@samvaity samvaity self-assigned this Jul 7, 2021
@samvaity samvaity requested a review from benbp as a code owner July 7, 2021 07:25
@samvaity samvaity changed the title Update recorded data usage in FormRecognizer Update recorded data usage in FormRecognizer tests infrastructure Jul 7, 2021
@check-enforcer
Copy link

check-enforcer bot commented Jul 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@samvaity samvaity force-pushed the update-recorded-data-usage branch from d3a7553 to 00bed56 Compare July 7, 2021 18:19
@samvaity
Copy link
Member Author

samvaity commented Jul 7, 2021

/azp run java - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@samvaity samvaity force-pushed the update-recorded-data-usage branch from 6c0bd0e to e94baba Compare July 8, 2021 18:16
@samvaity samvaity linked an issue Jul 8, 2021 that may be closed by this pull request
@samvaity samvaity merged commit 5bc8c64 into Azure:main Jul 8, 2021
@samvaity samvaity deleted the update-recorded-data-usage branch July 17, 2021 18:16
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Mar 2, 2023
{AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica (Azure#22799)

* {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica

fixes Azure/azure-rest-api-specs#22768 

The casing seems not correct in Swagger compared to Service.

e.g.: After setting SYNCHRONOUS_COMMIT as swagger said, the value returned by Get response is Synchronous_Commit
Similar issue happens for other properties in AgReplica

* Update sqlvm.json

* Update sqlvm.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Circular Usage of RecordedData in Form Recognizer Tests
2 participants