Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Circular Usage of RecordedData in Form Recognizer Tests #21633

Closed
alzimmermsft opened this issue May 18, 2021 · 0 comments · Fixed by #22799
Closed

Remove Circular Usage of RecordedData in Form Recognizer Tests #21633

alzimmermsft opened this issue May 18, 2021 · 0 comments · Fixed by #22799
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test bug Problem in test source code (most likely)

Comments

@alzimmermsft
Copy link
Member

Currently, some Form Recognizer tests depended on a deficiency in azure-core-test where network calls would be recorded when in PLAYBACK (PR fixing the deficiency). Resolving the deficiency resulted in Form Recognizer tests breaking as they attempt to read network calls that were read and remove but then added back due to recording of a recorded network call, now this network call is no longer being re-recorded.

Additionally, these tests are adding network calls to the recording from outside of the testing framework which generally shouldn't occur.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. test bug Problem in test source code (most likely) Cognitive - Form Recognizer labels May 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer test bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants