Disable select when only one domain exiists #29873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belcherj
added
the
[Status] Needs Review
|
Changes look good, and work fine. |
stephanethomas
added
[Status] Ready to Merge
G Suite
and removed
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Jan 3, 2019
…sh-2019 * origin/master: Disable select when only one domain exiists (#29873) Tiled galleries: Disable captions (#29776) Prevent scrolling up when opening a dialog (#29832) Gutenberg: Move Shortlinks to production (#29883) Gutenlypso: add convert to blocks dialog (#29790) Gutenberg: Move Related Posts to production blocks (#29650) Analytics: fix ad-tracking issue on signup for non-gdpr countries (#29741) Update mobile phone validation module (used for 2fa) (#29740) Gutenlypso: make sure titles load on second edit (#29877) Site Picker: Change wording of /page and /block-editor to match /post (#29859) Gutenberg: update copy link in page list to be editor aware Gutenberg: use core approach of initialEdits over overridePost Gutenberg: when duplicating a post, override post content Gutenberg: update duplicate url when Gutenlypso is enabled Refactor: Replace use of key-mirror with inline code (#29857) Fixes wrong selected domain name (#29824) Turn off prettier for SASS, use stylelint instead (#29697) Gutenberg: Add copy button to Shortlinks (#29556) add a section name to the body class (#29563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Goto a site with a 1 custom domain name
Goto domains->email
Click either Add G Suite User or Add G Suite
Observe that the domain select is not a dropdown
Goto a site with a 2 custom domain names
Goto domains->email
Click either Add G Suite User or Add G Suite
Observe that the domain select is a dropdown
Before:
After:
