Tiled galleries: Disable captions #29776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Status] Needs Review
|
Not that this invalidates existing blocks with captions. I do not expect restoring captions in the future to invalidate posts without captions. |
|
More |
simison
approved these changes
Dec 28, 2018
There was a problem hiding this comment.
Other than one piece of code that needs to be commented (and rebase obviously) this worked well.
Captions are a pretty essential feature so they'll need to be high on priority right after layouts.
Some issues with captions listed here and also outlined a way to bring them back but simplified; https://github.com/Automattic/wp-calypso/issues/29778
|
This works for me |
MichaelArestad
approved these changes
Dec 31, 2018
|
Going to rebase |
ockham
force-pushed
the
remove/g7g-tg-disable-caption
branch
from
c9255b6 to
4365ea7
Compare
|
ockham
approved these changes
Jan 3, 2019
matticbot
removed
the
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Jan 3, 2019
…sh-2019 * origin/master: Disable select when only one domain exiists (#29873) Tiled galleries: Disable captions (#29776) Prevent scrolling up when opening a dialog (#29832) Gutenberg: Move Shortlinks to production (#29883) Gutenlypso: add convert to blocks dialog (#29790) Gutenberg: Move Related Posts to production blocks (#29650) Analytics: fix ad-tracking issue on signup for non-gdpr countries (#29741) Update mobile phone validation module (used for 2fa) (#29740) Gutenlypso: make sure titles load on second edit (#29877) Site Picker: Change wording of /page and /block-editor to match /post (#29859) Gutenberg: update copy link in page list to be editor aware Gutenberg: use core approach of initialEdits over overridePost Gutenberg: when duplicating a post, override post content Gutenberg: update duplicate url when Gutenlypso is enabled Refactor: Replace use of key-mirror with inline code (#29857) Fixes wrong selected domain name (#29824) Turn off prettier for SASS, use stylelint instead (#29697) Gutenberg: Add copy button to Shortlinks (#29556) add a section name to the body class (#29563)
|
Thanks for bringing this home, folks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captions in Tiled Galleries closely match core gallery captions. They are functional, but present many challenges such as #29706
Disable captions for now by commenting them out.
Via p1545949443175900-slack-jetpack-gutenberg
Changes proposed in this Pull Request
Testing instructions