-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ad tracking gdpr signup issue #29741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicBosi
added
[Feature] Tracks Metrics & Monitoring
Capturing analytics about user behavior on WordPress.com.
[Status] In Progress
labels
Dec 24, 2018
MicBosi
force-pushed
the
fix/ad-tracking-gdpr-signup-issue
branch
from
December 24, 2018 15:25
6602151
to
f505dd3
Compare
MicBosi
requested review from
jaswrks and
lsinger
and removed request for
jaswrks
December 24, 2018 15:37
MicBosi
force-pushed
the
fix/ad-tracking-gdpr-signup-issue
branch
3 times, most recently
from
December 27, 2018 15:09
85d260a
to
a3ce6b6
Compare
MicBosi
force-pushed
the
fix/ad-tracking-gdpr-signup-issue
branch
from
December 31, 2018 13:37
60f2355
to
68b30c8
Compare
MicBosi
added
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
and removed
[Status] In Progress
labels
Dec 31, 2018
jaswrks
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :) Behaves as expected when testing from various countries. All of the trackers are continuing to fire in Ghostery whenever I test from a non-EU country.
jaswrks
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Jan 3, 2019
blowery
added a commit
that referenced
this pull request
Jan 3, 2019
…sh-2019 * origin/master: Disable select when only one domain exiists (#29873) Tiled galleries: Disable captions (#29776) Prevent scrolling up when opening a dialog (#29832) Gutenberg: Move Shortlinks to production (#29883) Gutenlypso: add convert to blocks dialog (#29790) Gutenberg: Move Related Posts to production blocks (#29650) Analytics: fix ad-tracking issue on signup for non-gdpr countries (#29741) Update mobile phone validation module (used for 2fa) (#29740) Gutenlypso: make sure titles load on second edit (#29877) Site Picker: Change wording of /page and /block-editor to match /post (#29859) Gutenberg: update copy link in page list to be editor aware Gutenberg: use core approach of initialEdits over overridePost Gutenberg: when duplicating a post, override post content Gutenberg: update duplicate url when Gutenlypso is enabled Refactor: Replace use of key-mirror with inline code (#29857) Fixes wrong selected domain name (#29824) Turn off prettier for SASS, use stylelint instead (#29697) Gutenberg: Add copy button to Shortlinks (#29556) add a section name to the body class (#29563)
Thanks, @jaswrks! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Tracks Metrics & Monitoring
Capturing analytics about user behavior on WordPress.com.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The issue: ad-tracking is blocked during signup for non-GDPR countries since country check relies on the
user
object which during signup is not available. So far this wasn't an issue because we weren't tracking signups but lately we have started doing so.Instead we now request the current country code using a logic that is coherent with the
A8C_Analytics
plugin that runs on wordpress.com homepage and landing pages, by simply using the https://public-api.wordpress.com/geo/ API and storing it to thecountry_code
cookie which is also used byA8C_Analytics
. The cookie expires and it's refreshed every 6 hours.Testing instructions
Test EU country:
localStorage
country_code
orsensitive_pixel_option
cookies setvisit the following address in Calypso, including flags required to enable ad-tracking:
country_code
cookie you might haveflags
above are still present in the URLcountry_code
cookie set to the country you are connecting fromTest non-EU country:
country_code
orsensitive_pixel_option
cookies setflags
above are still present in the URLcountry_code
cookie set to the country you are connecting fromTest signup
isAdTrackingAllowed: true
, visit/start/user/?flags=gdpr-banner,google-analytics,ad-tracking
, signup and create a new free account while keeping Chrome's Dev Tools open.cab35a3a79dc4173b8ce2c47adad2cea
: Icon Media retargeting pixeld239e9cb6d164f7299d2dbf7298f930a
: Icon Media signup pixelRegressions: