Turn off prettier for SASS, use stylelint instead #29697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
requested review from
a team,
jsnajdr and
sirreal
and removed request for
jsnajdr
blowery
added
Framework
[Status] Needs Review
sirreal
reviewed
Dec 26, 2018
| @if $size == $and-larger { | ||
| $approved-value: 2; | ||
| @media ( min-width: $breakpoint + 1 ) { | ||
| @content; | ||
| } | ||
| } @else { | ||
| } | ||
| @else { |
There was a problem hiding this comment.
These breaks before an else aren't aligned with our typical style. Can that be improved so the else is on the same line as braces?
There was a problem hiding this comment.
Nice spotting @sirreal 😉 Turns out this can be indeed improved by configuring the block-closing-brace-newline-after rule. The @if and @else SCSS statements are actually an example in the docs.
I updated the Stylelint config in 4a4a8be and updated the file formatting in 3fa79b6
We have been using prettier recently to format SCSS files. Unfortunately, prettier has a number of outstanding bugs with comments and formatting that can easily break code. This patch turns off prettier for sass files and uses stylelint instead. This has the added bonus of enforcing (or at least reporting) our stylelint rules, something that has been sorely missing until now.
jsnajdr
force-pushed
the
update/turn-off-prettier-for-sass
branch
from
e63bcef to
005f385
Compare
|
I rebased this PR onto the latest master, resolved conflicts that were introduced over the holidays, and patched the |
jsnajdr
approved these changes
Jan 2, 2019
matticbot
removed
the
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Jan 3, 2019
…sh-2019 * origin/master: Disable select when only one domain exiists (#29873) Tiled galleries: Disable captions (#29776) Prevent scrolling up when opening a dialog (#29832) Gutenberg: Move Shortlinks to production (#29883) Gutenlypso: add convert to blocks dialog (#29790) Gutenberg: Move Related Posts to production blocks (#29650) Analytics: fix ad-tracking issue on signup for non-gdpr countries (#29741) Update mobile phone validation module (used for 2fa) (#29740) Gutenlypso: make sure titles load on second edit (#29877) Site Picker: Change wording of /page and /block-editor to match /post (#29859) Gutenberg: update copy link in page list to be editor aware Gutenberg: use core approach of initialEdits over overridePost Gutenberg: when duplicating a post, override post content Gutenberg: update duplicate url when Gutenlypso is enabled Refactor: Replace use of key-mirror with inline code (#29857) Fixes wrong selected domain name (#29824) Turn off prettier for SASS, use stylelint instead (#29697) Gutenberg: Add copy button to Shortlinks (#29556) add a section name to the body class (#29563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier has a bunch of bugs with SASS formatting that can break our styles. However, our style linting solution,
stylelinthas a--fixoption much likeeslint. Let's try that instead...The first commit swaps prettier for eslint for sass files.
The second commit updates our stylelint rules to match our guidelines and fix some mistaken rule violations.
The last commit runs
--fixover all our sass files.This should have no visible impact.