[DO NOT MERGE] Detecting rotation gesture (AutoResizeTextView-based scaling refactor part 2) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
|
This one should be ready for review now 🙇 cc @aforcier |
7 tasks
…reen (even when it ends up being partially off screen)
aforcier
changed the base branch from
issue/153-textview-fontsize-cleanup
to
feature/adapt-gesture-listeners-fontsize
mzorz
changed the title
mzorz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #204
Trying to detect a rotation gesture and applying it to the
TextViewaccordingly.Known issue: currently this PR has an obvious issue: the coordinate system on the View is changed as we move our fingers so, on each iteration in the stream of MotionEvent the width/height may end up changing. Moving slow enough is useful to get an idea of how the effect is working.Fixed in 8aac73b
To test:
Note: the emoji will disappear as per Emoji disappears when zooming in too much #205 until Sets default maximum font size for emoji to 112sp #206 gets merged so, it's expected. Also note, the delete view will not appear while handling the emoji; this is a toDo item in [Primary] Adapt gesture listeners to cope with new width/height fontSize handling #207