[Primary] Adapt gesture listeners to cope with new width/height fontSize handling #207
Closed
6 of 7 tasks
Labels
Primary
A primary issue containing sub-items
[Type] Task
Something that needs be done, but is not necessarily a feature/bugfix itself.
won't fix
As part of tackling #153, #205, #66 and probably #180, we're changing the pinch to zoom behavior to change the TextView's fontSize to the extent it's applicable, and then only manipulate the View's
scale
when fontSize has already reached a limit.This is applicable to views based on
TextView
(emoji and text), but is not applicable to views based onImageView
(animated gif and such).For this, several things need be done:
PART 1:
PART 2:
2019-11-22 09:11:14.763 9332-9378/com.automattic.portkey E/OpenGLRenderer: Font size too large to fit in cache. width, height = 359, 338
(Sets default maximum font size for emoji to 112sp #206)PART 3:
PART 4:
PART 5:
ImageView
separately with the old, pre-existing listeners (could potentially be a step in the meantime), or incorporate the scale listener mechanism within the new listener scheme (in which case, we should remove the old classes if they end up not being used). EDIT: added handling of images with the new listener in 926b3ce in [DO NOT MERGE] Using TextViewSizeAwareTouchListener with Text views (scaling refactor part 4) #210The text was updated successfully, but these errors were encountered: