Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Primary] Adapt gesture listeners to cope with new width/height fontSize handling #207

Closed
6 of 7 tasks
mzorz opened this issue Nov 23, 2019 · 1 comment
Closed
6 of 7 tasks
Assignees
Labels
Primary A primary issue containing sub-items [Type] Task Something that needs be done, but is not necessarily a feature/bugfix itself. won't fix

Comments

@mzorz
Copy link
Contributor

mzorz commented Nov 23, 2019

As part of tackling #153, #205, #66 and probably #180, we're changing the pinch to zoom behavior to change the TextView's fontSize to the extent it's applicable, and then only manipulate the View's scale when fontSize has already reached a limit.

This is applicable to views based on TextView (emoji and text), but is not applicable to views based on ImageView(animated gif and such).

For this, several things need be done:
PART 1:

PART 2:

PART 3:

PART 4:

PART 5:

@mzorz mzorz added the [Type] Task Something that needs be done, but is not necessarily a feature/bugfix itself. label Nov 23, 2019
@mzorz mzorz self-assigned this Nov 23, 2019
@mzorz mzorz added the Primary A primary issue containing sub-items label Nov 23, 2019
@mzorz mzorz changed the title Adapt gesture listeners to cope with new width/height fontSize handling [Master] Adapt gesture listeners to cope with new width/height fontSize handling Nov 23, 2019
@mzorz mzorz added the won't fix label Dec 2, 2019
@mzorz
Copy link
Contributor Author

mzorz commented Dec 2, 2019

As explained in #153 (comment), closing this issue as won't fix, given the approach wasn't as fruitful as I thought after all

@mzorz mzorz closed this as completed Dec 2, 2019
@mzorz mzorz changed the title [Master] Adapt gesture listeners to cope with new width/height fontSize handling [Primary] Adapt gesture listeners to cope with new width/height fontSize handling Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary A primary issue containing sub-items [Type] Task Something that needs be done, but is not necessarily a feature/bugfix itself. won't fix
Projects
None yet
Development

No branches or pull requests

1 participant