Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch to zoom: change TextView fontSize #153

Closed
mzorz opened this issue Sep 19, 2019 · 2 comments
Closed

Pinch to zoom: change TextView fontSize #153

mzorz opened this issue Sep 19, 2019 · 2 comments
Assignees
Labels
[Type] Enhancement An improvement to existing functionality. won't fix

Comments

@mzorz
Copy link
Contributor

mzorz commented Sep 19, 2019

When zooming into a sticker or text, it's often the case it gets pixelated. We should not only change the visual rendering but also change the fontSize on the fly as the user pinches in/out, to avoid losing quality.

@mzorz mzorz added the [Type] Enhancement An improvement to existing functionality. label Sep 19, 2019
@mzorz mzorz self-assigned this Nov 8, 2019
@mzorz
Copy link
Contributor Author

mzorz commented Nov 11, 2019

To tackle this one, see technique used in #199

@mzorz
Copy link
Contributor Author

mzorz commented Dec 2, 2019

After intense search for a way that would work, a few things made us reach a conclusion that this issue should be closed with won't fix.

The sequence of PRs #204, #208, #209, #210, #211 and #214 (plus satellite PRs such as #206 and #213) are the trunk of this new solution involving the refactor of touch handlers, in an attempt to get the best of both worlds (view scaling and fontSize adjusting).

However, the impact and energy invested didn't prove to get us much gain, and introduces other problems. These are all described in the last PR #214 (comment).

For these reasons, closing this issue as we've decided to move on with other aspects of the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement An improvement to existing functionality. won't fix
Projects
None yet
1 participant