-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ras-acc): add reader account creation and login improvements #1716
Conversation
fix(ras-acc): merge trunk into epic/ras-acc
This PR addresses an issue where the renderer was not not respecting the social icons padding set in the editor. This also tweaks the default icons padding to 8px (from 7px) to be in-line with the spacing set in RAS-ACC transactional emails.
Fixes for reCAPTCHA implementation in RAS-ACC newsletter subscription block.
Merges release into epic/ras-acc as we are launching today and will need to base off of release going forward.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1716 +/- ##
============================================
+ Coverage 23.20% 23.23% +0.02%
- Complexity 2716 2722 +6
============================================
Files 49 49
Lines 10776 10780 +4
============================================
+ Hits 2501 2505 +4
Misses 8275 8275 ☔ View full report in Codecov by Sentry. |
Hey @chickenn00dle, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [3.6.0-alpha.1](v3.5.0...v3.6.0-alpha.1) (2024-11-29) ### Bug Fixes * let the exceptions be thrown ([#1698](#1698)) ([85746b8](85746b8)) ### Features * **ras-acc:** add reader account creation and login improvements ([#1716](#1716)) ([4640cae](4640cae)) * rate limit requests for CC ([#1714](#1714)) ([ad092ca](ad092ca))
🎉 This PR is included in version 3.6.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR merges the epic/ras-acc branch into trunk.
How to test the changes in this Pull Request:
Apply this PR as well as the relevant PRs in plugin, blocks, and theme then do some RAS-ACC smoke tests.
Other information: