Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ras-acc): add reader account creation and login improvements #1716

Merged
merged 19 commits into from
Nov 28, 2024

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Nov 27, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR merges the epic/ras-acc branch into trunk.

How to test the changes in this Pull Request:

Apply this PR as well as the relevant PRs in plugin, blocks, and theme then do some RAS-ACC smoke tests.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

laurelfulford and others added 19 commits August 8, 2024 17:48
fix(ras-acc): merge trunk into epic/ras-acc
This PR addresses an issue where the renderer was not not respecting the social icons padding set in the editor. This also tweaks the default icons padding to 8px (from 7px) to be in-line with the spacing set in RAS-ACC transactional emails.
Fixes for reCAPTCHA implementation in RAS-ACC newsletter subscription block.
Merges release into epic/ras-acc as we are launching today and will need to base off of release going forward.
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.23%. Comparing base (656befb) to head (49c9b30).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #1716      +/-   ##
============================================
+ Coverage     23.20%   23.23%   +0.02%     
- Complexity     2716     2722       +6     
============================================
  Files            49       49              
  Lines         10776    10780       +4     
============================================
+ Hits           2501     2505       +4     
  Misses         8275     8275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurelfulford laurelfulford merged commit 4640cae into trunk Nov 28, 2024
11 checks passed
@laurelfulford laurelfulford deleted the epic/ras-acc branch November 28, 2024 18:40
Copy link

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 29, 2024
# [3.6.0-alpha.1](v3.5.0...v3.6.0-alpha.1) (2024-11-29)

### Bug Fixes

* let the exceptions be thrown ([#1698](#1698)) ([85746b8](85746b8))

### Features

* **ras-acc:** add reader account creation and login improvements ([#1716](#1716)) ([4640cae](4640cae))
* rate limit requests for CC ([#1714](#1714)) ([ad092ca](ad092ca))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants