Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rate limit requests for CC #1714

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds a rate limit for Constant Contact request. It should not make more than 4 requests per second.

How to test the changes in this Pull Request:

1.Smoke test a Constant Contact connection

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani self-assigned this Nov 25, 2024
@leogermani leogermani requested a review from a team as a code owner November 25, 2024 13:45
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.07%. Comparing base (5ec8c54) to head (9692d02).
Report is 5 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #1714      +/-   ##
============================================
+ Coverage     23.00%   23.07%   +0.07%     
- Complexity     2710     2713       +3     
============================================
  Files            49       49              
  Lines         10751    10761      +10     
============================================
+ Hits           2473     2483      +10     
  Misses         8278     8278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leogermani leogermani merged commit ad092ca into trunk Nov 26, 2024
10 checks passed
@leogermani leogermani deleted the feat/constant-contact-rate-limit branch November 26, 2024 19:14
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 29, 2024
# [3.6.0-alpha.1](v3.5.0...v3.6.0-alpha.1) (2024-11-29)

### Bug Fixes

* let the exceptions be thrown ([#1698](#1698)) ([85746b8](85746b8))

### Features

* **ras-acc:** add reader account creation and login improvements ([#1716](#1716)) ([4640cae](4640cae))
* rate limit requests for CC ([#1714](#1714)) ([ad092ca](ad092ca))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants