-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update base branch to release #1706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpha release Nov 06
# [3.4.0-alpha.1](v3.3.2...v3.4.0-alpha.1) (2024-11-06) ### Bug Fixes * avoid race condition between post-save sync & test ([#1679](#1679)) ([7bde119](7bde119)) * avoid Redux usage and related errors in non-newsletter email editors ([#1688](#1688)) ([d3f1f37](d3f1f37)) * dont html encode ampersands in subject ([#1686](#1686)) ([f178b23](f178b23)) * **mailchimp:** avoid duplicate audiences in Mailchimp UIs ([#1685](#1685)) ([44c1b12](44c1b12)) * move Preview, Send buttons to match Publish button location ([#1689](#1689)) ([72897f2](72897f2)) * preview & send buttons on WP 6.7 ([49450d3](49450d3)) ### Features * display list remote name on settings page ([#1672](#1672)) ([562d396](562d396))
## [3.3.3](v3.3.2...v3.3.3) (2024-11-07) ### Bug Fixes * **send-lists:** temporary fix for searching many mailchimp audiences ([#1693](#1693)) ([e41f3b6](e41f3b6))
# [3.4.0-alpha.2](v3.4.0-alpha.1...v3.4.0-alpha.2) (2024-11-07) ### Bug Fixes * **send-lists:** temporary fix for searching many mailchimp audiences ([#1693](#1693)) ([e41f3b6](e41f3b6))
# [3.4.0-alpha.3](v3.4.0-alpha.2...v3.4.0-alpha.3) (2024-11-08) ### Bug Fixes * correct button stacking on sent newsletters ([#1695](#1695)) ([4e2688e](4e2688e))
Bumps [newspack-components](https://github.com/Automattic/newspack-plugin/tree/HEAD/src/components) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/Automattic/newspack-plugin/releases) - [Changelog](https://github.com/Automattic/newspack-plugin/blob/trunk/CHANGELOG.md) - [Commits](https://github.com/Automattic/newspack-plugin/commits/v3.1.0/src/components) --- updated-dependencies: - dependency-name: newspack-components dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
* fix: remove behavior to hide post title in newsletter editor * fix: remove the useEffect
Alpha release Nov 11
# [3.4.0-alpha.4](v3.4.0-alpha.3...v3.4.0-alpha.4) (2024-11-11) ### Bug Fixes * remove behavior to hide post title in newsletter editor ([#1701](#1701)) ([8a15cf5](8a15cf5))
Alpha release Nov 11
# [3.4.0-alpha.5](v3.4.0-alpha.4...v3.4.0-alpha.5) (2024-11-11) ### Bug Fixes * avoid double notice components ([#1703](#1703)) ([b8e9130](b8e9130))
Release Nov 11
# [3.4.0](v3.3.3...v3.4.0) (2024-11-11) ### Bug Fixes * avoid double notice components ([#1703](#1703)) ([b8e9130](b8e9130)) * avoid race condition between post-save sync & test ([#1679](#1679)) ([7bde119](7bde119)) * avoid Redux usage and related errors in non-newsletter email editors ([#1688](#1688)) ([d3f1f37](d3f1f37)) * correct button stacking on sent newsletters ([#1695](#1695)) ([4e2688e](4e2688e)) * dont html encode ampersands in subject ([#1686](#1686)) ([f178b23](f178b23)) * **mailchimp:** avoid duplicate audiences in Mailchimp UIs ([#1685](#1685)) ([44c1b12](44c1b12)) * move Preview, Send buttons to match Publish button location ([#1689](#1689)) ([72897f2](72897f2)) * preview & send buttons on WP 6.7 ([49450d3](49450d3)) * remove behavior to hide post title in newsletter editor ([#1701](#1701)) ([8a15cf5](8a15cf5)) ### Features * display list remote name on settings page ([#1672](#1672)) ([562d396](562d396))
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic/ras-acc #1706 +/- ##
===============================================
Coverage ? 20.41%
Complexity ? 2670
===============================================
Files ? 48
Lines ? 10623
Branches ? 0
===============================================
Hits ? 2169
Misses ? 8454
Partials ? 0 ☔ View full report in Codecov by Sentry. |
laurelfulford
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Merges release into epic/ras-acc as we are launching today and will need to base off of release going forward.
How to test the changes in this Pull Request:
Smoke test RAS-ACC
Other information: