Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage: Remove Plugin Update Cards from Settings and Dashboard #17003

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Manage: Remove Plugin Update Cards from Settings and Dashboard #17003

merged 1 commit into from
Sep 1, 2020

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Aug 27, 2020 •
edited
Loading

Fixes #16933

Changes proposed in this Pull Request:

  • Removes the plugin update card (for auto-updating plugins) from both the Settings and Dashboard pages.
Settings
Before After
Screen Shot 2020-08-21 at 1 33 28 PM Screen Shot 2020-08-21 at 1 32 57 PM
Dashboard
Before After
Screen Shot 2020-08-27 at 5 53 29 PM Screen Shot 2020-08-27 at 5 47 43 PM

Jetpack product discussion

Plugin auto-updates were added in WordPress 5.5

Does this pull request change what data or activity we track or use?

No changes.

Testing instructions:

  • Go to '/wp-admin/admin.php?page=jetpack#/settings'
  • There should be no auto-update plugins card
  • Go to '/wp-admin/admin.php?page=jetpack#/dashboard'
  • There should be no auto-update plugins card

Proposed changelog entry for your changes:

  • Remove plugin update cards from Settings and Dashboard pages

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17003

Scheduled Jetpack release: September 1, 2020.
Scheduled code freeze: August 25, 2020

Generated by 🚫 dangerJS against 54b1146

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu labels Aug 28, 2020
@allilevine allilevine marked this pull request as ready for review August 28, 2020 16:10
@allilevine allilevine changed the title [WIP] Manage: Remove Plugin Update Cards from Settings and Dashboard Manage: Remove Plugin Update Cards from Settings and Dashboard Aug 28, 2020
@aaronrobertshaw aaronrobertshaw requested a review from a team August 31, 2020 04:51
aaronrobertshaw
aaronrobertshaw approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

  • Prior to checking out PR branch, plugin update cards were displayed.
  • After applying this the plugin cards were not shown.

@aaronrobertshaw aaronrobertshaw added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Aug 31, 2020
@jeherve jeherve added this to the 9.0 milestone Sep 1, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 1, 2020
jeherve
jeherve approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🚢

@allilevine allilevine merged commit cb462a7 into master Sep 1, 2020
@allilevine allilevine deleted the update/16933-remove-plugin-update-cards branch September 1, 2020 13:43
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 1, 2020
davidlonjon added a commit that referenced this pull request Sep 1, 2020
@davidlonjon
Merge branch 'master' into update/lazy-images-assets-package-dependency
5582cf4 
* master:
  Remove plugin update cards from settings and dashboard (#17003)
  Update version numbers to start 9.9 cycle (#17043)
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@allilevine @pereirinha
[not verified] Remove plugin update cards from settings and dashboard (…
f4a4e65 
…#17003)
jeherve added a commit that referenced this pull request Sep 25, 2020
@jeherve
Changelog: add #17003
5125bb2
anomiex added a commit that referenced this pull request May 10, 2022
@anomiex
jetpack: Remove unused JS client components
e58a88a 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle
@anomiex anomiex mentioned this pull request May 10, 2022
Merged
anomiex added a commit that referenced this pull request May 10, 2022
@anomiex @kraftbj
jetpack: Remove unused JS client components (#24319)
d878bee 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle

Co-authored-by: Brandon Kraft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

Assignees

@allilevine allilevine

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Manage: Remove Plugin Update Card
5 participants
@allilevine @jetpackbot @jeherve @aaronrobertshaw @matticbot