Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage: Remove Plugin Update Card #16933

Closed
kraftbj opened this issue Aug 21, 2020 · 6 comments · Fixed by #17003
Closed

Manage: Remove Plugin Update Card #16933

kraftbj opened this issue Aug 21, 2020 · 6 comments · Fixed by #17003
Assignees
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Manage [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Aug 21, 2020

screen-shot-2020-07-17-at-4 41 42-pm

With Core adding this functionality, until our backup/restore integrations are in place, we should remove this card to avoid confusion.

Steps to reproduce the issue

n/a

What I expected

n/a

What happened instead

n/a

@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Manage Admin Page React-powered dashboard under the Jetpack menu labels Aug 21, 2020
@dereksmart
Copy link
Member

When we look into this, let's also consider the one on the main dashboard
image

@pablinos
Copy link
Contributor

I'd missed this feature being merged. Perhaps we could check for the presence of wp_is_auto_update_enabled_for_type and use that to determine whether to disable this UI?

@jeherve
Copy link
Member

jeherve commented Aug 24, 2020

Perhaps we could check for the presence of wp_is_auto_update_enabled_for_type and use that to determine whether to disable this UI?

Since that's a Core feature now, I'd be tempted to not mention the feature at all in the Jetpack dashboard, at least not until we've made some improvements to our implementation so it's better than Core's.

@pablinos
Copy link
Contributor

That makes sense. I suppose I was thinking about people that were on < WP 5.5, but then any change would be in a new version of Jetpack they would need to update to also.

@allilevine allilevine self-assigned this Aug 25, 2020
@allilevine
Copy link
Member

allilevine commented Aug 25, 2020

Since that's a Core feature now, I'd be tempted to not mention the feature at all in the Jetpack dashboard, at least not until we've made some improvements to our implementation so it's better than Core's.

Should we hide the feature from the dashboard (e.g. with a feature/config flag)? Or remove it from the code entirely since it will be implemented differently if it comes back?

@jeherve
Copy link
Member

jeherve commented Aug 26, 2020

I think it'd be safe to remove entirely. We can always pull the code back if needed later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Manage [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants