Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modal for paid features #12118

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Remove modal for paid features #12118

merged 2 commits into from
Apr 24, 2019

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Apr 22, 2019 •
edited
Loading

Fixes #12116

Changes proposed in this Pull Request:

  • removes all the code and options related to the modal for paid features

Testing instructions:

  • Go to Jetpack settings, everything should work normally.
  • There's nothing to test because everything was removed.

Proposed changelog entry for your changes:

  • Not needed. Part of Module Prioritization

@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Apr 22, 2019
@eliorivero eliorivero added this to the 7.3 milestone Apr 22, 2019
@eliorivero eliorivero requested review from MichaelArestad and a team April 22, 2019 21:17
@eliorivero eliorivero self-assigned this Apr 22, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 22, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 7cb0696

oskosk
oskosk reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like _inc/client/scss/style.scss still contains a reference to /components/welcome-new-plan/style.scss which is removed in this PR, thus the build is not working

@oskosk oskosk added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 23, 2019
@eliorivero eliorivero added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 24, 2019
jeherve
jeherve approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. I spotted an error when clicking on the upgrade buttons in the Plans screen (Uncaught TypeError: Cannot read property 'props' of undefined, pointing to clickHandler() in the TopButton component, but that doesn't seem related to this PR.

👍 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 24, 2019
@oskosk oskosk mentioned this pull request Apr 24, 2019
Merged
oskosk
oskosk approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve Your observation is addressed by #12136

MichaelArestad
MichaelArestad approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me a little sad, but works as expected.

@oskosk oskosk merged commit a9fc6fd into master Apr 24, 2019
@oskosk oskosk deleted the remove/welcome-new-plan branch April 24, 2019 16:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 24, 2019
anomiex added a commit that referenced this pull request May 10, 2022
@anomiex
jetpack: Remove unused JS client components
e58a88a 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle
@anomiex anomiex mentioned this pull request May 10, 2022
Merged
anomiex added a commit that referenced this pull request May 10, 2022
@anomiex @kraftbj
jetpack: Remove unused JS client components (#24319)
d878bee 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle

Co-authored-by: Brandon Kraft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@oskosk oskosk oskosk approved these changes

@MichaelArestad MichaelArestad MichaelArestad approved these changes

Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Remove the modal for paid plan features
7 participants
@eliorivero @jetpackbot @jeherve @oskosk @MichaelArestad @kraftbj @matticbot