Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/separate code signing identity #99

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Feature/separate code signing identity #99

merged 2 commits into from
Nov 11, 2024

Conversation

minsusun
Copy link
Contributor

Description

Provide code signing identity only on CI/CD

Fixes #98

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

GItHub Actions should be executed to be tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@minsusun minsusun requested a review from Abdenasser as a code owner November 11, 2024 02:37
Abdenasser
Abdenasser approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Abdenasser Abdenasser merged commit d9d4095 into Abdenasser:main Nov 11, 2024
2 checks passed
@minsusun minsusun deleted the feature/separate-code-signing-identity branch November 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdenasser Abdenasser Abdenasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling code signing only on CI/CD
2 participants
@minsusun @Abdenasser