Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/separate code signing identity #99

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Feature/separate code signing identity #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a452b65
feat: provide code signing identity only on CI/CD
minsusun Nov 11, 2024
dbdb150
doc: revert #89
minsusun Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/macos-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Build for Intel Mac
run: |
echo "Building for Intel Mac..."
npm run tauri build -- --target x86_64-apple-darwin --bundles dmg
npm run tauri build -- --target x86_64-apple-darwin --bundles dmg --config "{\"bundle\":{\"macOS\":{\"signingIdentity\": \"Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)\"}}}"
# Rename the Intel build and store the filename
cd src-tauri/target/x86_64-apple-darwin/release/bundle/dmg/
for f in *.dmg; do
Expand All @@ -66,7 +66,7 @@ jobs:
- name: Build for Apple Silicon
run: |
echo "Building for aarch64..."
npm run tauri build -- --target aarch64-apple-darwin --bundles dmg
npm run tauri build -- --target aarch64-apple-darwin --bundles dmg --config "{\"bundle\":{\"macOS\":{\"signingIdentity\": \"Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)\"}}}"
# Rename the Apple Silicon build and store the filename
cd src-tauri/target/aarch64-apple-darwin/release/bundle/dmg/
for f in *.dmg; do
Expand Down
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ npm run tauri dev

# Build for production
npm run tauri build

# Build for local mac(Bypass code signing)
npm run tauri build -- --bundles app --config "{\"bundle\":{\"macOS\":{\"signingIdentity\":null}}}"
```

### Development Setup
Expand Down
1 change: 0 additions & 1 deletion src-tauri/tauri.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"icons/icon.ico"
],
"macOS": {
"signingIdentity": "Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)",
"hardenedRuntime": true,
"entitlements": null,
"providerShortName": null
Expand Down
Loading