Merge pull request #99 from minsusun/feature/separate-code-signing-id…

…entity Feature/separate code signing identity
Abdenasser · Nov 11, 2024 · d9d4095 · d9d4095
2 parents 761bc3b + dbdb150
commit d9d4095
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/macos-nightly.yml b/.github/workflows/macos-nightly.yml
@@ -51,7 +51,7 @@ jobs:
       - name: Build for Intel Mac
         run: |
           echo "Building for Intel Mac..."
-          npm run tauri build -- --target x86_64-apple-darwin --bundles dmg
+          npm run tauri build -- --target x86_64-apple-darwin --bundles dmg --config "{\"bundle\":{\"macOS\":{\"signingIdentity\": \"Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)\"}}}"
           # Rename the Intel build and store the filename
           cd src-tauri/target/x86_64-apple-darwin/release/bundle/dmg/
           for f in *.dmg; do 
@@ -66,7 +66,7 @@ jobs:
       - name: Build for Apple Silicon
         run: |
           echo "Building for aarch64..."
-          npm run tauri build -- --target aarch64-apple-darwin --bundles dmg
+          npm run tauri build -- --target aarch64-apple-darwin --bundles dmg --config "{\"bundle\":{\"macOS\":{\"signingIdentity\": \"Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)\"}}}"
           # Rename the Apple Silicon build and store the filename
           cd src-tauri/target/aarch64-apple-darwin/release/bundle/dmg/
           for f in *.dmg; do 

diff --git a/README.md b/README.md
@@ -59,9 +59,6 @@ npm run tauri dev
 
 # Build for production
 npm run tauri build
-
-# Build for local mac(Bypass code signing)
-npm run tauri build -- --bundles app --config "{\"bundle\":{\"macOS\":{\"signingIdentity\":null}}}"
 ```
 
 ### Development Setup

diff --git a/src-tauri/tauri.conf.json b/src-tauri/tauri.conf.json
@@ -16,7 +16,6 @@
       "icons/icon.ico"
     ],
     "macOS": {
-      "signingIdentity": "Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)",
       "hardenedRuntime": true,
       "entitlements": null,
       "providerShortName": null