Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add setups for mac local build #89

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

minsusun
Copy link
Contributor

Description

Provided a new commands on README.md which can be used on building locally on Mac machine.

This command by-passes the code signing by overriding null identity to tauri build with parameters.

Partially fixes #88

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

# before
# omit vite build
> Using @sveltejs/adapter-static
  Wrote site to "build"done
   Compiling macos-task-manager v1.0.8 (/Users/user/Desktop/workspace/develop/neohtop/src-tauri)
    Finished `release` profile [optimized] target(s) in 51.05s
    Built application at: /Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/NeoHtop
    Bundling NeoHtop.app (/Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/bundle/macos/NeoHtop.app)
    Signing with identity "Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)"
Signing with identity "Developer ID Application: Abdenasser Elidrissi (785JV74B9Y)"
Signing /Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/bundle/macos/NeoHtop.app/Contents/MacOS/NeoHtop
error: The specified item could not be found in the keychain.
failed to bundle project: failed to sign app
# after
# omit vite build
> Using @sveltejs/adapter-static
  Wrote site to "build"done
   Compiling macos-task-manager v1.0.8 (/Users/user/Desktop/workspace/develop/neohtop/src-tauri)
    Finished `release` profile [optimized] target(s) in 53.68s
    Built application at: /Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/NeoHtop
    Bundling NeoHtop.app (/Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/bundle/macos/NeoHtop.app)
    Finished 1 bundle at:
        /Users/user/Desktop/workspace/develop/neohtop/src-tauri/target/release/bundle/macos/NeoHtop.app

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@minsusun minsusun requested a review from Abdenasser as a code owner November 10, 2024 12:47
@minsusun minsusun force-pushed the feature/guide-local-mac-build branch from c47909e to c170e20 Compare November 10, 2024 12:49
Copy link
Owner

@Abdenasser Abdenasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @minsusun

@Abdenasser Abdenasser merged commit 1706644 into Abdenasser:main Nov 10, 2024
@minsusun minsusun deleted the feature/guide-local-mac-build branch November 10, 2024 13:01
minsusun added a commit to minsusun/neohtop that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to bundle project: failed to sign app
2 participants