ADD: addition of subset_radar function in radar_utils #1227

wolfidan · 2022-07-27T19:46:07Z

Dear Py-ART team,

In this PR I propose the addition of a ~~cut_radar~~ subset_radar function from our MeteoSwiss fork of the library (thanks @jfigui). It cuts a radar object to a new domain specified by bounds in range, azimuth and elevation, and returns a new object. It can be useful to make processing faster when one is interested only in a certain subdomain around the radar (typically shorter ranges and only a certain sector).
This function is used a lot in our pyrad library, which is a framework for real time radar processing that relies on PyART.
I also added a short test function that checks if a cut radar object has indeed coordinates that match with the specified bounds.
Cheers,
Daniel W.

mgrover1

One small suggestion - other than that, looks great! Thanks for adding tests!

mgrover1 · 2022-07-27T19:50:03Z

pyart/util/radar_utils.py

@@ -104,6 +104,203 @@ def to_vpt(radar, single_scan=True):
    return


+def cut_radar(radar, field_names, rng_min=None, rng_max=None, ele_min=None,


This all looks great! One small suggestion - what would you think about changing the name here to subset_radar?

wolfidan · 2022-07-28T08:34:15Z

Thanks for the feedback @mgrover1, it's done

wolfidan · 2022-07-28T09:47:59Z

Could you help me with this failing check, I have honestly no idea what failed here in the website deploy?

mgrover1 · 2022-07-28T12:02:20Z

@wolfidan we updated the trmm_rsl feedstock, changing the path in our CI. I added the fix here, should fix the problem. Thanks for making those changes!

zssherman · 2022-07-28T13:29:14Z

@mgrover1 looks like it's still not finding trmm_rsl, the full path on condaforge has a weird extension now before the 4 and after the package name

zssherman · 2022-07-28T13:30:34Z

And it's different between osx and Linux for some reason... hmmm

mgrover1 · 2022-07-28T15:07:48Z

I updated the TRMM rsl path - it was incorrect...

wolfidan · 2022-07-28T18:16:17Z

Thanks for your help!

mgrover1 · 2022-08-11T18:34:03Z

@zssherman I think we can go ahead and merge - let's fix the TRMM_RSL for linux in a different PR

* add cookbook section (#1199) * TST: Adding unitests for rain rate module. (#1200) * fix missing < symbol in link (#1201) * add pypi stats to readme (#1206) * FIX: update join_radar to also append instrument parameters (#1204) * updated join_radar to also append instrument parameters * updated join_radar to also append instrument parameters * add pypi stats to readme (#1206) * updated join_radar to also append instrument parameters * updated join_radar to also append instrument parameters * added unittest for join_radar Co-authored-by: Max Grover <[email protected]> * TST: Moving tests to test module within Py-ART main directory. (#1207) * TST: Moving pyart main module tests to test directory. * TSTS: Move bridge and core submodules to respective test directories. * TSTS: Moving correct and filters tests to respective tests directories. * TST: Moving graph io and map test modules. * TST: Moving retrieve, testing and util submodule tests. * FIX: Remove pyargs * FIX: Fix pytest call. * FIX: Remove extra netcdf reference. * MNT: Remove duplicate pytest as well. * MNT: Changing custom config path. * FIX: Fix for config loading and not resetting. * TST: Adding back in test_simualted_vel. * FIX: Fix for missing sys paths. * FIX: Attemped PIL fix. * MNT: Remove pillow. * FIX: Fix for only python 3.10 being used. (#1208) * FIX: Fix for only python 3.10 being used. * FIX: Adding python call. * MNT: Another attempt. * FIX: Xarray pin removed. * MNT: Remove cftime pin. * MNT: Attemped fix for pil. * MNT: Accidently removed gdal * MNT: Pinning for now. * MNT: Remove lib set. * CI: Remove python 3.6 from testing. * remove pinning for specific cftime (#1211) * DOC: Updating Py-ART's how to release doc and removing most of ci_setup doc (#1213) * DOC: Updating Py-ART's how to release doc and removing most of ci_setup. * DOC: Changes reflecting review. * ENH: Corrected Height Gates to be height above sea level (#1215) * ENH: Corrected Height Gates to be height above sea level * FIX: Removed character within comment line * ENH: Updated Height Test to include altitude of radar. * TST: Fix median filter depreciation warnings as well as more tests for simple moments. (#1214) * TST: Fix median filter depreciation warnings as well as more tests for simple moments. * TST: Update values. * MNT: Adding variables for simple moment calculation functions. * FIX: Removal of depreciation warning for interp namespace. * fix writing IRIS sigmet files to UF (#1216) * FIX: join_radar also joins pulse repititon times iparam (#1218) * Add pyrad to the readme (#1220) * add pyrad to the readme * move pyrad to extension section * add space between _ and : * FIX: Return zero phase for sweeps completely filtered out with gatefi… (#1226) * FIX: Return zero phase for sweeps completely filtered out with gatefilter. * FIX: Remove debug statement * Trmm test (#1228) * TST: To see if trmm_rsl broke. * MNT: Forgot final else. * MNT: Remove full path. * add hardcoded trmm_rsl path to docs * add missing RSL_PATH= * upin cftime * build docs on macos * update to macos hash * add macos latest runner for docs * add macOS-latest * move toward micromamba * change path to micromamba * add ls and move to mamba exe * try pkgs dir Co-authored-by: mgrover1 <[email protected]> Co-authored-by: Max Grover <[email protected]> * remove load module section (#1234) * DOC: Updated pyart doc to include column code, fix incorrect syntax and more. (#1231) * DOC: Updated pyart doc to include column code, incorrect syntax and more. * DOC: Forgot https * MNT: Revert ssh to https * MNT: Suggested changes. * ADD: addition of subset_radar function in radar_utils (#1227) * added cut_radar function in util * added cut_radar function in util * renamed cut_radar to subset_radar * MNT: Update ci.yml. * MNT: Updating environments. * MNT: Duplicate 'latest' * MNT: Revert back os runner check. * MNT: Add bash to each run Co-authored-by: zssherman <[email protected]> * MNT: Remove trmm_rsl from CI optional, remove from debug info. (#1239) * CI: Remove trmm_rsl from testing. * MNT: Remove trmm_rsl from debug and install warning build message. * CI: Remove trmm_rsl pathing from CI. * MNT: Remove warning from setup.py * remove trmm_rsl from doc env * MNT: Don't code cover deprecated code. * replace dealias with region based * use cfradial with rhi two panel * add new plot ppi cfradial remove old one using sigmet * use cfradial with xsect example Co-authored-by: mgrover1 <[email protected]> * add tests for xradar * make sure CI runs on the xradar branch * add datatree as pip and fix missing import * remove python 3.7 * fix incorrect xradar test * update __init__.py * remove chunk arg Co-authored-by: Zach Sherman <[email protected]> Co-authored-by: Daniel Wolfensberger <[email protected]> Co-authored-by: Joe O'Brien <[email protected]> Co-authored-by: Sam Gardner <[email protected]> Co-authored-by: Bobby Jackson <[email protected]> Co-authored-by: zssherman <[email protected]>

wolfidan added 2 commits July 27, 2022 21:37

added cut_radar function in util

eefbf79

added cut_radar function in util

94a268b

mgrover1 requested changes Jul 27, 2022

View reviewed changes

wolfidan added 2 commits July 28, 2022 10:28

Merge branch 'ARM-DOE:main' into main

062f018

renamed cut_radar to subset_radar

ff2ec27

wolfidan changed the title ~~ADD: addition of cut_radar function in radar_utils~~ ADD: addition of subset_radar function in radar_utils Jul 28, 2022

mgrover1 approved these changes Jul 28, 2022

View reviewed changes

mgrover1 requested a review from zssherman July 28, 2022 12:45

zssherman closed this Aug 2, 2022

zssherman reopened this Aug 2, 2022

zssherman closed this Aug 2, 2022

zssherman reopened this Aug 2, 2022

zssherman added 6 commits August 10, 2022 14:05

Merge branch 'main' of github.com:ARM-DOE/pyart into wolfidan/main

e9a5adf

MNT: Update ci.yml.

763566e

MNT: Updating environments.

fa6d6d0

MNT: Duplicate 'latest'

6e36233

MNT: Revert back os runner check.

5cee702

MNT: Add bash to each run

32c68b6

zssherman merged commit a623736 into ARM-DOE:main Aug 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADD: addition of subset_radar function in radar_utils #1227

ADD: addition of subset_radar function in radar_utils #1227

wolfidan commented Jul 27, 2022 •

edited

Loading

mgrover1 left a comment

mgrover1 Jul 27, 2022

wolfidan commented Jul 28, 2022

wolfidan commented Jul 28, 2022

mgrover1 commented Jul 28, 2022

zssherman commented Jul 28, 2022

zssherman commented Jul 28, 2022

mgrover1 commented Jul 28, 2022

wolfidan commented Jul 28, 2022

mgrover1 commented Aug 11, 2022

		@@ -104,6 +104,203 @@ def to_vpt(radar, single_scan=True):
		return


		def cut_radar(radar, field_names, rng_min=None, rng_max=None, ele_min=None,

ADD: addition of subset_radar function in radar_utils #1227

ADD: addition of subset_radar function in radar_utils #1227

Conversation

wolfidan commented Jul 27, 2022 • edited Loading

mgrover1 left a comment

Choose a reason for hiding this comment

mgrover1 Jul 27, 2022

Choose a reason for hiding this comment

wolfidan commented Jul 28, 2022

wolfidan commented Jul 28, 2022

mgrover1 commented Jul 28, 2022

zssherman commented Jul 28, 2022

zssherman commented Jul 28, 2022

mgrover1 commented Jul 28, 2022

wolfidan commented Jul 28, 2022

mgrover1 commented Aug 11, 2022

wolfidan commented Jul 27, 2022 •

edited

Loading