Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: join_radar also joins pulse repititon times iparam #1218

Merged
merged 1 commit into from
Jul 24, 2022
Merged

FIX: join_radar also joins pulse repititon times iparam #1218

merged 1 commit into from
Jul 24, 2022

Conversation

wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Jul 24, 2022

In the current version of py-ART, joining two radar files using pyart.util.join_radar(rdr1, rdr2) produces a radar object that contains PRT data only from rdr1.

This commit appends the PRT data from rdr2

This is necessary because if the joined radar object is then exported to universal format using pyart.io.write_uf, the rays from the second radar object don't have PRT data, causing an out-of-bounds array traceback.

@scollis
Copy link
Member

scollis commented Jul 24, 2022

Just sliding on in and saying thank you @wx4stg for the PRs!

@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 24, 2022

it may be more desired to refactor all of L148 through 163 to instead of join iparams fields individually by name, use a for loop through took look through all of the iparams in radar1, and if radar2 has the same parameter, append the arrays of data.

However if some of the parameters have only a single value instead of an array, this could produce unexpected/invalid results... I don't have much experience which filetypes provide which parameters and what's considered valid

@zssherman
Copy link
Collaborator

@wx4stg Thanks for the fix! I agree, a loop to append and look through the params is ideal. What I could do is accept this for now, and i can look into creating an actually loop, testing on the file in the previous PR.

@zssherman zssherman merged commit 0a71096 into ARM-DOE:main Jul 24, 2022
@wx4stg
Copy link
Contributor Author

wx4stg commented Jul 24, 2022

yeah, that would also fix #1095

mgrover1 added a commit that referenced this pull request Aug 24, 2022
@mgrover1 @zssherman
@wolfidan @jrobrien91 @wx4stg @rcjackson
Add xradar basic functions (#1251)
306e6ab 
* add cookbook section (#1199)

* TST: Adding unitests for rain rate module. (#1200)

* fix missing < symbol in link (#1201)

* add pypi stats to readme (#1206)

* FIX: update join_radar to also append instrument parameters (#1204)

* updated join_radar to also append instrument parameters

* updated join_radar to also append instrument parameters

* add pypi stats to readme (#1206)

* updated join_radar to also append instrument parameters

* updated join_radar to also append instrument parameters

* added unittest for join_radar

Co-authored-by: Max Grover <[email protected]>

* TST: Moving tests to test module within Py-ART main directory. (#1207)

* TST: Moving pyart main module tests to test directory.

* TSTS: Move bridge and core submodules to respective test directories.

* TSTS: Moving correct and filters tests to respective tests directories.

* TST: Moving graph io and map test modules.

* TST: Moving retrieve, testing and util submodule tests.

* FIX: Remove pyargs

* FIX: Fix pytest call.

* FIX: Remove extra netcdf reference.

* MNT: Remove duplicate pytest as well.

* MNT: Changing custom config path.

* FIX: Fix for config loading and not resetting.

* TST: Adding back in test_simualted_vel.

* FIX: Fix for missing sys paths.

* FIX: Attemped PIL fix.

* MNT: Remove pillow.

* FIX: Fix for only python 3.10 being used. (#1208)

* FIX: Fix for only python 3.10 being used.

* FIX: Adding python call.

* MNT: Another attempt.

* FIX: Xarray pin removed.

* MNT: Remove cftime pin.

* MNT: Attemped fix for pil.

* MNT: Accidently removed gdal

* MNT: Pinning for now.

* MNT: Remove lib set.

* CI: Remove python 3.6 from testing.

* remove pinning for specific cftime (#1211)

* DOC: Updating Py-ART's how to release doc and removing most of ci_setup doc (#1213)

* DOC: Updating Py-ART's how to release doc and removing most of ci_setup.

* DOC: Changes reflecting review.

* ENH: Corrected Height Gates to be height above sea level (#1215)

* ENH: Corrected Height Gates to be height above sea level

* FIX: Removed character within comment line

* ENH: Updated Height Test to include altitude of radar.

* TST: Fix median filter depreciation warnings as well as more tests for simple moments. (#1214)

* TST: Fix median filter depreciation warnings as well as more tests for
simple moments.

* TST: Update values.

* MNT: Adding variables for simple moment calculation functions.

* FIX: Removal of depreciation warning for interp namespace.

* fix writing IRIS sigmet files to UF (#1216)

* FIX: join_radar also joins pulse repititon times iparam (#1218)

* Add pyrad to the readme (#1220)

* add pyrad to the readme

* move pyrad to extension section

* add space between _ and :

* FIX: Return zero phase for sweeps completely filtered out with gatefi… (#1226)

* FIX: Return zero phase for sweeps completely filtered out with gatefilter.

* FIX: Remove debug statement

* Trmm test (#1228)

* TST: To see if trmm_rsl broke.

* MNT: Forgot final else.

* MNT: Remove full path.

* add hardcoded trmm_rsl path to docs

* add missing RSL_PATH=

* upin cftime

* build docs on macos

* update to macos hash

* add macos latest runner for docs

* add macOS-latest

* move toward micromamba

* change path to micromamba

* add ls and move to mamba exe

* try pkgs dir

Co-authored-by: mgrover1 <[email protected]>
Co-authored-by: Max Grover <[email protected]>

* remove load module section (#1234)

* DOC: Updated pyart doc to include column code, fix incorrect syntax and more. (#1231)

* DOC: Updated pyart doc to include column code, incorrect syntax and
more.

* DOC: Forgot https

* MNT: Revert ssh to https

* MNT: Suggested changes.

* ADD: addition of subset_radar function in radar_utils (#1227)

* added cut_radar function in util

* added cut_radar function in util

* renamed cut_radar to subset_radar

* MNT: Update ci.yml.

* MNT: Updating environments.

* MNT: Duplicate 'latest'

* MNT: Revert back os runner check.

* MNT: Add bash to each run

Co-authored-by: zssherman <[email protected]>

* MNT: Remove trmm_rsl from CI optional, remove from debug info. (#1239)

* CI: Remove trmm_rsl from testing.

* MNT: Remove trmm_rsl from debug and install warning build message.

* CI: Remove trmm_rsl pathing from CI.

* MNT: Remove warning from setup.py

* remove trmm_rsl from doc env

* MNT: Don't code cover deprecated code.

* replace dealias with region based

* use cfradial with rhi two panel

* add new plot ppi cfradial remove old one using sigmet

* use cfradial with xsect example

Co-authored-by: mgrover1 <[email protected]>

* add tests for xradar

* make sure CI runs on the xradar branch

* add datatree as pip and fix missing import

* remove python 3.7

* fix incorrect xradar test

* update __init__.py

* remove chunk arg

Co-authored-by: Zach Sherman <[email protected]>
Co-authored-by: Daniel Wolfensberger <[email protected]>
Co-authored-by: Joe O'Brien <[email protected]>
Co-authored-by: Sam Gardner <[email protected]>
Co-authored-by: Bobby Jackson <[email protected]>
Co-authored-by: zssherman <[email protected]>
@mgrover1 mgrover1 mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wx4stg @scollis @zssherman