ENH: Corrected Height Gates to be height above sea level #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to pull upstream changes before submitting, so my testing directories are messed up. I'll take a look at this tonight/tomorrow morning and commit changes |
|
@jrobrien91 The unit tests just need to be updated to reflect the changes. |
… into column_correct_xr because I'm an idiot
|
Forgot I wrote a height test. Sorry about that! |
zssherman
approved these changes
Jul 22, 2022
mgrover1
added a commit
that referenced
this pull request
Aug 24, 2022
* add cookbook section (#1199) * TST: Adding unitests for rain rate module. (#1200) * fix missing < symbol in link (#1201) * add pypi stats to readme (#1206) * FIX: update join_radar to also append instrument parameters (#1204) * updated join_radar to also append instrument parameters * updated join_radar to also append instrument parameters * add pypi stats to readme (#1206) * updated join_radar to also append instrument parameters * updated join_radar to also append instrument parameters * added unittest for join_radar Co-authored-by: Max Grover <[email protected]> * TST: Moving tests to test module within Py-ART main directory. (#1207) * TST: Moving pyart main module tests to test directory. * TSTS: Move bridge and core submodules to respective test directories. * TSTS: Moving correct and filters tests to respective tests directories. * TST: Moving graph io and map test modules. * TST: Moving retrieve, testing and util submodule tests. * FIX: Remove pyargs * FIX: Fix pytest call. * FIX: Remove extra netcdf reference. * MNT: Remove duplicate pytest as well. * MNT: Changing custom config path. * FIX: Fix for config loading and not resetting. * TST: Adding back in test_simualted_vel. * FIX: Fix for missing sys paths. * FIX: Attemped PIL fix. * MNT: Remove pillow. * FIX: Fix for only python 3.10 being used. (#1208) * FIX: Fix for only python 3.10 being used. * FIX: Adding python call. * MNT: Another attempt. * FIX: Xarray pin removed. * MNT: Remove cftime pin. * MNT: Attemped fix for pil. * MNT: Accidently removed gdal * MNT: Pinning for now. * MNT: Remove lib set. * CI: Remove python 3.6 from testing. * remove pinning for specific cftime (#1211) * DOC: Updating Py-ART's how to release doc and removing most of ci_setup doc (#1213) * DOC: Updating Py-ART's how to release doc and removing most of ci_setup. * DOC: Changes reflecting review. * ENH: Corrected Height Gates to be height above sea level (#1215) * ENH: Corrected Height Gates to be height above sea level * FIX: Removed character within comment line * ENH: Updated Height Test to include altitude of radar. * TST: Fix median filter depreciation warnings as well as more tests for simple moments. (#1214) * TST: Fix median filter depreciation warnings as well as more tests for simple moments. * TST: Update values. * MNT: Adding variables for simple moment calculation functions. * FIX: Removal of depreciation warning for interp namespace. * fix writing IRIS sigmet files to UF (#1216) * FIX: join_radar also joins pulse repititon times iparam (#1218) * Add pyrad to the readme (#1220) * add pyrad to the readme * move pyrad to extension section * add space between _ and : * FIX: Return zero phase for sweeps completely filtered out with gatefi… (#1226) * FIX: Return zero phase for sweeps completely filtered out with gatefilter. * FIX: Remove debug statement * Trmm test (#1228) * TST: To see if trmm_rsl broke. * MNT: Forgot final else. * MNT: Remove full path. * add hardcoded trmm_rsl path to docs * add missing RSL_PATH= * upin cftime * build docs on macos * update to macos hash * add macos latest runner for docs * add macOS-latest * move toward micromamba * change path to micromamba * add ls and move to mamba exe * try pkgs dir Co-authored-by: mgrover1 <[email protected]> Co-authored-by: Max Grover <[email protected]> * remove load module section (#1234) * DOC: Updated pyart doc to include column code, fix incorrect syntax and more. (#1231) * DOC: Updated pyart doc to include column code, incorrect syntax and more. * DOC: Forgot https * MNT: Revert ssh to https * MNT: Suggested changes. * ADD: addition of subset_radar function in radar_utils (#1227) * added cut_radar function in util * added cut_radar function in util * renamed cut_radar to subset_radar * MNT: Update ci.yml. * MNT: Updating environments. * MNT: Duplicate 'latest' * MNT: Revert back os runner check. * MNT: Add bash to each run Co-authored-by: zssherman <[email protected]> * MNT: Remove trmm_rsl from CI optional, remove from debug info. (#1239) * CI: Remove trmm_rsl from testing. * MNT: Remove trmm_rsl from debug and install warning build message. * CI: Remove trmm_rsl pathing from CI. * MNT: Remove warning from setup.py * remove trmm_rsl from doc env * MNT: Don't code cover deprecated code. * replace dealias with region based * use cfradial with rhi two panel * add new plot ppi cfradial remove old one using sigmet * use cfradial with xsect example Co-authored-by: mgrover1 <[email protected]> * add tests for xradar * make sure CI runs on the xradar branch * add datatree as pip and fix missing import * remove python 3.7 * fix incorrect xradar test * update __init__.py * remove chunk arg Co-authored-by: Zach Sherman <[email protected]> Co-authored-by: Daniel Wolfensberger <[email protected]> Co-authored-by: Joe O'Brien <[email protected]> Co-authored-by: Sam Gardner <[email protected]> Co-authored-by: Bobby Jackson <[email protected]> Co-authored-by: zssherman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analysis of CMAC2.0 processed radar files, the extracted radar column heights did not match the calculated CMAC2.0 heights. Additionally, get_fields_location failed with CMAC2.0 files. This was determined to be due to attempting to set the dimension of the DataSet with the same name as one of the CMAC2.0 fields (e.g. 'height').
Testing showed that the extracted radar column heights were not heights above sea level and were also interpolating gates based on the range edges.
To fix this, the altitude of the radar was added to extracted radar column height gates and edges option on antenna_vectors_to_cartesian was set to 'False'.
Check was added for a 'height' field within the radar object.
'Base_time' and "time_offset" data variables were added to the DataSet to conform to the ARM standards. 'base_time' corresponds to the time units within the radar file. 'time_offset' are the times to the center of each height gate.
Various DataSet attributes are set to update meta data for the extracted column.